Skip to content

Skip capture-side boost controls in ALSA volume detection #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Oct 26, 2026
Merged

Skip capture-side boost controls in ALSA volume detection #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sendspin/alsa_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,10 @@ async def _has_playback_volume(card: int | str, element: str) -> bool:
return False
if proc.returncode != 0:
return False
caps = set(stdout.decode().split())
return "pvolume" in caps or "volume" in caps
output = stdout.decode()
caps = set(output.split())
# Codecs also tag capture-side gain stages with a bare `volume` capability.
return "pvolume" in caps or ("volume" in caps and "Capture channels:" not in output)


async def find_mixer_element(card: int | str) -> str | None:
Expand Down
32 changes: 32 additions & 0 deletions tests/test_alsa_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,38 @@ async def fake_exec(*argv: object, **kwargs: object) -> _FakeProcess:
assert await find_mixer_element(3) is None


async def test_find_mixer_element_capability_scan_skips_capture_boost(monkeypatch) -> None:
"""Capability scan skips the RT5616 'ADC Boost' capture gain tagged with bare `volume`."""
scontrols_output = "Simple mixer control 'ADC Boost',0\nSimple mixer control 'DAC1',0\n"
sget_adc_boost = (
"Simple mixer control 'ADC Boost',0\n"
" Capabilities: volume\n"
" Playback channels: Front Left - Front Right\n"
" Capture channels: Front Left - Front Right\n"
" Limits: 0 - 3\n"
" Front Left: 0 [0%] [0.00dB]\n"
" Front Right: 0 [0%] [0.00dB]\n"
)
sget_dac1 = (
"Simple mixer control 'DAC1',0\n"
" Capabilities: pvolume\n"
" Playback channels: Front Left - Front Right\n"
" Limits: Playback 0 - 175\n"
" Front Left: Playback 175 [100%] [0.00dB]\n"
" Front Right: Playback 175 [100%] [0.00dB]\n"
)

async def fake_exec(*argv: object, **kwargs: object) -> _FakeProcess:
if "scontrols" in argv:
return _FakeProcess(stdout=scontrols_output.encode())
if "ADC Boost" in argv:
return _FakeProcess(stdout=sget_adc_boost.encode())
return _FakeProcess(stdout=sget_dac1.encode())

monkeypatch.setattr(asyncio, "create_subprocess_exec", fake_exec)
assert await find_mixer_element(2) == "DAC1"


# -- AlsaVolumeController.set_state ------------------------------------------


Expand Down
Loading