Skip to content

[Android][Lint] Set max line length in detekt to 140 and enable lint rule - #589

Merged
kiftio merged 2 commits into
mainfrom
08-05-set_max_line_length_in_detekt_to_140
Sep 1, 2026
Merged

[Android][Lint] Set max line length in detekt to 140 and enable lint rule#589
kiftio merged 2 commits into
mainfrom
08-05-set_max_line_length_in_detekt_to_140

Conversation

@kiftio

@kiftio kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Adds a MaxLineLength rule to the detekt configuration for the Android demo app, enforcing a maximum line length of 140 characters.

How to test

Run detekt on the Android demo app and verify that lines exceeding 140 characters are flagged as violations.


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Aug 6, 2026

kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@kiftio kiftio changed the title set max line length in detekt to 140 [Android][Lint] Set max line length in detekt to 140 and enable lint rule Aug 6, 2026
@kiftio
kiftio force-pushed the 08-05-enable_function_naming_lint branch 2 times, most recently from 23aa4ec to de8ea2e Compare August 6, 2026 15:34
@kiftio
kiftio force-pushed the 08-05-set_max_line_length_in_detekt_to_140 branch from 303d2b7 to 3f240f9 Compare August 6, 2026 15:35
@kiftio
kiftio marked this pull request as ready for review August 7, 2026 10:08
@kiftio
kiftio requested a review from a team as a code owner August 7, 2026 10:08
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 364.8 KiB 364.8 KiB 0 B
Android file breakdown
File Base Head Delta
classes.jar 388.4 KiB 388.4 KiB 0 B
res/layout/checkout_view_content.xml 2.6 KiB 2.6 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.3 KiB 1.3 KiB 0 B
R.txt 1.2 KiB 1.2 KiB 0 B
AndroidManifest.xml 922 B 922 B 0 B
proguard.txt 798 B 798 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@bitrise

bitrise Bot commented Aug 7, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Kotlin Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml kotlin android latest Google Pixel 9
Android 17.0

Base automatically changed from 08-05-enable_function_naming_lint to main September 1, 2026 15:04
@kiftio
kiftio force-pushed the 08-05-set_max_line_length_in_detekt_to_140 branch from 46eb8c2 to d993c23 Compare September 1, 2026 15:23

kiftio commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Sep 1, 3:30 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 1, 3:30 PM UTC: @kiftio merged this pull request with Graphite.

@kiftio
kiftio merged commit 83ba4e6 into main Sep 1, 2026
34 of 35 checks passed
@kiftio
kiftio deleted the 08-05-set_max_line_length_in_detekt_to_140 branch September 1, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants