Enable additional Android sample lint rules - #611
Merged
Conversation
11 tasks
This was referenced Aug 7, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 7, 2026
kiftio
marked this pull request as ready for review
August 10, 2026 08:16
Package Size
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
approved these changes
Aug 10, 2026
kiftio
changed the base branch from
08-05-enable_magic_number_check
to
graphite-base/611
September 1, 2026 15:31
Assisted-By: devx/e2f77bde-d08f-41c4-a14f-b50a215d784a
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
kiftio
force-pushed
the
graphite-base/611
branch
from
September 1, 2026 16:17
604573d to
f76387a
Compare
kiftio
force-pushed
the
08-07-enable_additional_android_sample_lint_rules
branch
from
September 1, 2026 16:17
ac9bf1a to
a8eb5cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
The Android sample app's Detekt configuration has been updated to use the full set of default rules (
buildUponDefaultConfig = true) rather than a limited subset. Instead of only enforcing formatting, function naming, and magic number checks, the sample now runs all default Detekt rules with targeted opt-outs for known existing sample debt (e.g.LongMethod,TooManyFunctions,CyclomaticComplexMethod,ReturnCount, etc.). This makes static analysis more actionable going forward without surfacing unrelated pre-existing issues.How to test
./gradlew :app:detekt@Composableand@Testannotated functions with PascalCase or backtick names do not triggerFunctionNamingviolations.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.