Skip to content

Enable additional Android sample lint rules - #611

Merged
kiftio merged 7 commits into
mainfrom
08-07-enable_additional_android_sample_lint_rules
Sep 2, 2026
Merged

Enable additional Android sample lint rules#611
kiftio merged 7 commits into
mainfrom
08-07-enable_additional_android_sample_lint_rules

Conversation

@kiftio

@kiftio kiftio commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

The Android sample app's Detekt configuration has been updated to use the full set of default rules (buildUponDefaultConfig = true) rather than a limited subset. Instead of only enforcing formatting, function naming, and magic number checks, the sample now runs all default Detekt rules with targeted opt-outs for known existing sample debt (e.g. LongMethod, TooManyFunctions, CyclomaticComplexMethod, ReturnCount, etc.). This makes static analysis more actionable going forward without surfacing unrelated pre-existing issues.

How to test

  1. Run the Detekt task against the Android sample: ./gradlew :app:detekt
  2. Confirm the build passes without unexpected new violations.
  3. Introduce a violation covered by a non-opted-out rule (e.g. an inline magic number) and confirm Detekt flags it.
  4. Confirm that Compose @Composable and @Test annotated functions with PascalCase or backtick names do not trigger FunctionNaming violations.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 364.8 KiB 364.8 KiB 0 B
Android file breakdown
File Base Head Delta
classes.jar 388.4 KiB 388.4 KiB 0 B
res/layout/checkout_view_content.xml 2.6 KiB 2.6 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.3 KiB 1.3 KiB 0 B
R.txt 1.2 KiB 1.2 KiB 0 B
AndroidManifest.xml 922 B 922 B 0 B
proguard.txt 798 B 798 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@bitrise

bitrise Bot commented Aug 10, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Kotlin Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
kotlin-android kotlin android latest Google Pixel 9
Android 17.0

@kiftio
kiftio changed the base branch from 08-05-enable_magic_number_check to graphite-base/611 September 1, 2026 15:31
Assisted-By: devx/e2f77bde-d08f-41c4-a14f-b50a215d784a
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
Assisted-By: devx/62a938bf-9923-4194-bbbf-562a92be16c5
@kiftio
kiftio force-pushed the 08-07-enable_additional_android_sample_lint_rules branch from ac9bf1a to a8eb5cb Compare September 1, 2026 16:17
@kiftio
kiftio changed the base branch from graphite-base/611 to main September 1, 2026 16:18
@kiftio
kiftio merged commit c47ed86 into main Sep 2, 2026
31 checks passed
@kiftio
kiftio deleted the 08-07-enable_additional_android_sample_lint_rules branch September 2, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants