[Performance] Optimize sanitizedHeadersOutput header sanitization - #8338
[Performance] Optimize sanitizedHeadersOutput header sanitization#8338gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
sanitizedHeadersOutputis called frequently when verbose logging or unit testing HTTP and GraphQL API requests/responses. Previously, it performed multiple object allocations and redundant iterations:header.toLowerCase()for every keyword inSENSITIVE_HEADERSinside a.find()callback on each header.sanitizedobject usingforEach.sanitizedwithObject.keys()a second time to map into output strings.WHAT is this pull request doing?
Refactors
sanitizedHeadersOutputto use single-passObject.entries(headers)filtering:!SENSITIVE_HEADERS.some(...).Object.keys()lookups.How to test your changes?
Run any CLI command with
--verboseflag (e.g.shopify app info --verbose) or execute API-related tests.Post-release steps
None.
Measuring impact
Checklist
PR created automatically by Jules for task 2168919330683522285 started by @gonzaloriestra