Skip to content

[Performance] Optimize sanitizedHeadersOutput header sanitization #8338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −63
Draft

[Performance] Optimize sanitizedHeadersOutput header sanitization #8338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/cli-kit/src/private/node/api/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,13 @@ export function sanitizedHeadersOutput(headers: Record<string, string>): string
return ''
}

const sanitized: Record<string, string> = {}
Object.keys(headers).forEach((header) => {
if (SENSITIVE_HEADERS.find((keyword) => header.toLowerCase().includes(keyword)) === undefined) {
sanitized[header] = headers[header]!
}
})
return Object.keys(sanitized)
.map((header) => {
return ` - ${header}: ${sanitized[header]}`
// Optimize header sanitization by single-pass filtering with cached lowercasing and short-circuit boolean checking
return Object.entries(headers)
.filter(([header]) => {
const lowerHeader = header.toLowerCase()
return !SENSITIVE_HEADERS.some((keyword) => lowerHeader.includes(keyword))
})
.map(([header, value]) => ` - ${header}: ${value}`)
.join('\n')
}

Expand Down
Loading
Loading