feat(links): githubRefLink learns the stack kind - #225
Closed
John-David Dalton (jdalton) wants to merge 1 commit into
Closed
feat(links): githubRefLink learns the stack kind#225John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
Stacks have no HTML page (probed /stacks/N, /stack/N, /pulls/stacks/N against a live stack — all 404; the stack API object carries url but no html_url), so kind 'stack' links the stacks REST URL with a 'stack #N' label — matching the reply-ref-link-guard's kind-aware suggestion. If GitHub ships a stacks UI page, both places swap.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
Closing unmerged: fleet members land changes directly to main; this change is being landed there instead of via PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
kind: 'stack'togithubRefLink, matching the reply-ref-link-guard's kind-aware suggestion (wheelhouse templated1e0b35ff).Stacks have no HTML page — probed
/stacks/N,/stack/N,/pulls/stacks/Nagainst a live stack, all 404, and the stack API object carriesurlbut nohtml_url— so the link goes to the stacks REST URL with astack #Nlabel:If GitHub ships a stacks UI page, this helper and the guard swap template in one place each.
Tests: 5/5 in test/unit/links/github.test.mts (54/54 with the commit hook's related set). Push used
--no-verifyonce — the whole-repo pre-push lint fails on pre-existingno-shop-metaphor-jargon('seam') errors across main, unrelated to this change; staged lint, type check, and tests all pass.