Repository navigation
refactor(plugins): stamp the PluginKit version from one build setting - #3498
Merged
Merged
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The PluginKit version was a Swift literal in
PluginManager.swift, copied by hand into every plugin plist, and four scripts grepped it out of Swift. Step 12 of the release rewrite.Change
Configs/PluginKit.xcconfigholds the current and minimum kit;Base.xcconfigincludes it.TableProPluginKitVersionstays an<integer>. The app'sInfo.plistcarries both values forPluginManager, which fails a precondition when one is missing.DriverPlugintemplate signs with the team and the hardened runtime and strips in Release;Base.xcconfig's signing comment says so. Plugin test bundles stop borrowing a plugin's plist.build-plugin.yml,build.yml,release-plugin-for-shipped-app.shand the bump-cadence check read the xcconfig; older tags fall back to Swift.Verified
BundledPluginStampTestsfails when a plugin plist stamps the kit as a string. Every plugin builds with an integer kit and loads, in Debug and in a Release probe.Not in this PR
BundledPluginStampTestschecks the kit only: pluginCFBundleVersionequals the app's after step 23 drops the template'sCURRENT_PROJECT_VERSION: 1.plutil -lintby design; no CI step lints them.TableProProvides*from each plugin's Swift ids, with a plist == Swift check, is a follow-up.check-pluginkit-abi.sh, whose advice still namescurrentPluginKitVersion, and drops the cadence step inrepo-hygiene.yml.CONTRIBUTING.md:42still says plugins sign ad hoc;RELEASING.mdis rewritten later.