🔒 Fix missing process capability check in std.notification - #107
Conversation
Added capability checking logic in both the `show` and `alert` functions in `stdlib/src/notification.rs` to verify that `Capability::Process` is granted, as they both run external processes. Updated the `required_capabilities` in the `std.notification` module registration to include `Capability::Process`. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a security vulnerability where external processes (
⚠️ Risk: Scripts without process execution capabilities could bypass the sandbox policy and run arbitrary commands (via UI alerts/notifications) if they utilized the
powershell,msg,notify-send) were spawned instdlib/src/notification.rs(showandalertfunctions) without validating if the script hadCapability::Processgranted.std.notificationmodule, leading to unauthorized host execution.🛡️ Solution: Added explicit
ctx.config.capabilities.contains(&Capability::Process)checks to both theshowandalertfunction callbacks. If the capability is denied, it returns aRuntimeError(RuntimeErrorKind::InvalidOperation). Also registeredCapability::Processas a required capability for thestd.notificationmodule.PR created automatically by Jules for task 16110128204199656425 started by @Tcode-Motion