Skip to content

🔒 Fix missing process capability check in std.notification #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 1 commit into from
Sep 8, 2026
Merged

🔒 Fix missing process capability check in std.notification #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions stdlib/src/notification.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
use crate::{StdFunction, StdlibModule, StdlibRegistry};
use std::collections::HashMap;
use std::rc::Rc;
use techscript_runtime::{error::RuntimeError, value::RuntimeValue};
use techscript_runtime::{
context::Capability,
error::{RuntimeError, RuntimeErrorKind},
value::RuntimeValue,
};

impl StdlibRegistry {
pub fn register_notification(&mut self) {
Expand All @@ -13,7 +17,17 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "show".to_string(),
arity: 2,
callback: |_ctx, args| {
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::Process) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: Process capability is denied"
.to_string(),
),
None,
None,
));
}
let title = args[0].to_string();
let body = args[1].to_string();
#[cfg(target_os = "windows")]
Expand Down Expand Up @@ -46,7 +60,17 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "alert".to_string(),
arity: 1,
callback: |_ctx, args| {
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::Process) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: Process capability is denied"
.to_string(),
),
None,
None,
));
}
let msg = args[0].to_string();
#[cfg(target_os = "windows")]
{
Expand All @@ -69,7 +93,7 @@ impl StdlibRegistry {
name: "std.notification".to_string(),
version: "1.0.0".to_string(),
exports,
required_capabilities: Vec::new(),
required_capabilities: vec![Capability::Process],
},
);
}
Expand Down
Loading