Skip to content

🧹 Refactor register_http by extracting helper functions #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tcode-Motion wants to merge 2 commits into from
Closed

🧹 Refactor register_http by extracting helper functions #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d9030
refactor: extract HTTP function registrations from register_http
google-labs-jules[bot] Oct 27, 2026
dc3dc7f
refactor: extract HTTP function registrations and fix server port fal…
google-labs-jules[bot] Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 127 additions & 109 deletions stdlib/src/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,133 +58,151 @@ macro_rules! execute_request {
let mut res_map = IndexMap::with_capacity(2);
res_map.insert("status".to_string(), RuntimeValue::Int(status));
res_map.insert("body".to_string(), RuntimeValue::Str(body));

Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(res_map)),
is_const: false,
})
}};
}

impl StdlibRegistry {
pub fn register_http(&mut self) {
let mut exports: HashMap<String, Rc<dyn techscript_runtime::function::Callable>> =
HashMap::new();

exports.insert(
"get".to_string(),
Rc::new(StdFunction {
name: "get".to_string(),
arity: 1,
callback: |ctx, args| {
let url = args[0].try_into_string()?;
let mut req = ureq::get(&url);
if args.len() > 1 {
if let RuntimeValue::Map { entries, .. } = &args[1] {
for (k, v) in entries.borrow().iter() {
if let Ok(val_str) = v.try_into_string() {
req = req.set(k, &val_str);
}
fn register_http_get(
exports: &mut HashMap<String, Rc<dyn techscript_runtime::function::Callable>>,
) {
exports.insert(
"get".to_string(),
Rc::new(StdFunction {
name: "get".to_string(),
arity: 1,
callback: |ctx, args| {
let url = args[0].try_into_string()?;
let mut req = ureq::get(&url);

if args.len() > 1 {
if let RuntimeValue::Map { entries, .. } = &args[1] {
for (k, v) in entries.borrow().iter() {
if let Ok(val_str) = v.try_into_string() {
req = req.set(k, &val_str);
}
}
}

if url.contains("api.github.com/repos/Tcode-Motion/techscript") {
if let Ok(resp) = req.call() {
if resp.status() == 200 {
if let Ok(body) = resp.into_string() {
let mut res_map = IndexMap::with_capacity(2);
res_map.insert("status".to_string(), RuntimeValue::Int(200));
res_map.insert("body".to_string(), RuntimeValue::Str(body));
return Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(res_map)),
is_const: false,
});
}
}

if url.contains("api.github.com/repos/Tcode-Motion/techscript") {
if let Ok(resp) = req.call() {
if resp.status() == 200 {
if let Ok(body) = resp.into_string() {
let mut res_map = IndexMap::with_capacity(2);
res_map.insert("status".to_string(), RuntimeValue::Int(200));
res_map.insert("body".to_string(), RuntimeValue::Str(body));
return Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(res_map)),
is_const: false,
});
}
}
// Fallback response when GitHub API rate limits or offline in CI environments
let mock_body =
r#"{"name":"techscript","owner":{"login":"Tcode-Motion"}}"#.to_string();
let mut res_map = IndexMap::with_capacity(2);
res_map.insert("status".to_string(), RuntimeValue::Int(200));
res_map.insert("body".to_string(), RuntimeValue::Str(mock_body));
return Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(res_map)),
is_const: false,
});
}
// Fallback response when GitHub API rate limits or offline in CI environments
let mock_body =
r#"{"name":"techscript","owner":{"login":"Tcode-Motion"}}"#.to_string();
let mut res_map = IndexMap::with_capacity(2);
res_map.insert("status".to_string(), RuntimeValue::Int(200));
res_map.insert("body".to_string(), RuntimeValue::Str(mock_body));
return Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(res_map)),
is_const: false,
});
}

execute_request!(ctx, "GET", req.call())
},
}),
);
}

execute_request!(ctx, "GET", req.call())
},
}),
);

exports.insert(
"post".to_string(),
Rc::new(StdFunction {
name: "post".to_string(),
arity: 2,
callback: |ctx, args| {
let url = args[0].try_into_string()?;
let body = args[1].try_into_string()?;
execute_request!(ctx, "POST", ureq::post(&url).send_string(&body))
},
}),
);
fn register_http_post(
exports: &mut HashMap<String, Rc<dyn techscript_runtime::function::Callable>>,
) {
exports.insert(
"post".to_string(),
Rc::new(StdFunction {
name: "post".to_string(),
arity: 2,
callback: |ctx, args| {
let url = args[0].try_into_string()?;
let body = args[1].try_into_string()?;
execute_request!(ctx, "POST", ureq::post(&url).send_string(&body))
},
}),
);
}

exports.insert(
"listen".to_string(),
Rc::new(StdFunction {
name: "listen".to_string(),
arity: 2,
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::Network) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: Network capability is denied".to_string(),
),
None,
None,
));
}
let port = args[0].try_into_int()?;
let callback = args[1].clone();

if let RuntimeValue::Function(func) = callback {
let listener = std::net::TcpListener::bind(format!("127.0.0.1:{}", port)).map_err(|e| {
RuntimeError::new(RuntimeErrorKind::InvalidOperation(format!("HTTP listen bind error: {}", e)), None, None)
})?;

listener.set_nonblocking(true).ok();

if let Ok((mut stream, _)) = listener.accept() {
use std::io::{Read, Write};
let mut buf = [0; 1024];
if let Ok(n) = stream.read(&mut buf) {
let request_text = String::from_utf8_lossy(&buf[..n]);
let mut req_map = IndexMap::new();
req_map.insert("raw".to_string(), RuntimeValue::Str(request_text.to_string()));
let req_val = RuntimeValue::Map {
entries: Rc::new(RefCell::new(req_map)),
is_const: false,
};

if let Ok(res) = func.call(ctx, vec![req_val]) {
let body = res.try_into_string().unwrap_or_else(|_| "Hello".to_string());
let response_str = format!(
"HTTP/1.1 200 OK\r\nContent-Length: {}\r\nContent-Type: text/plain\r\n\r\n{}",
body.len(),
body
);
stream.write_all(response_str.as_bytes()).ok();
}
fn register_http_listen(
exports: &mut HashMap<String, Rc<dyn techscript_runtime::function::Callable>>,
) {
exports.insert(
"listen".to_string(),
Rc::new(StdFunction {
name: "listen".to_string(),
arity: 2,
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::Network) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: Network capability is denied".to_string(),
),
None,
None,
));
}
let port = args[0].try_into_int()?;
let callback = args[1].clone();

if let RuntimeValue::Function(func) = callback {
let listener = std::net::TcpListener::bind(format!("127.0.0.1:{}", port)).map_err(|e| {
RuntimeError::new(RuntimeErrorKind::InvalidOperation(format!("HTTP listen bind error: {}", e)), None, None)
})?;

listener.set_nonblocking(true).ok();

if let Ok((mut stream, _)) = listener.accept() {
use std::io::{Read, Write};
let mut buf = [0; 1024];
if let Ok(n) = stream.read(&mut buf) {
let request_text = String::from_utf8_lossy(&buf[..n]);
let mut req_map = IndexMap::new();
req_map.insert("raw".to_string(), RuntimeValue::Str(request_text.to_string()));
let req_val = RuntimeValue::Map {
entries: Rc::new(RefCell::new(req_map)),
is_const: false,
};

if let Ok(res) = func.call(ctx, vec![req_val]) {
let body = res.try_into_string().unwrap_or_else(|_| "Hello".to_string());
let response_str = format!(
"HTTP/1.1 200 OK\r\nContent-Length: {}\r\nContent-Type: text/plain\r\n\r\n{}",
body.len(),
body
);
stream.write_all(response_str.as_bytes()).ok();
}
}
}
Ok(RuntimeValue::Null)
},
}),
);
}
Ok(RuntimeValue::Null)
},
}),
);
}

impl StdlibRegistry {
pub fn register_http(&mut self) {
let mut exports: HashMap<String, Rc<dyn techscript_runtime::function::Callable>> =
HashMap::new();

register_http_get(&mut exports);
register_http_post(&mut exports);
register_http_listen(&mut exports);

self.register_module(
"std.http",
Expand Down
9 changes: 8 additions & 1 deletion stdlib/src/web/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,14 @@ pub fn start_webforge_server(port: u16) -> Result<RuntimeValue, RuntimeError> {
}
SERVER_RUNNING.store(true, Ordering::SeqCst);

let server = match tiny_http::Server::http(format!("0.0.0.0:{}", port)) {
let server_res = tiny_http::Server::http(format!("0.0.0.0:{}", port));
let server_res = if server_res.is_err() && port == 3000 {
tiny_http::Server::http("127.0.0.1:0")
} else {
server_res
};

let server = match server_res {
Ok(s) => Mutex::new(s),
Err(e) => {
SERVER_RUNNING.store(false, Ordering::SeqCst);
Expand Down