Skip to content

🧹 [code health improvement description] Refactor Display formatters in token_kind.rs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 1 commit into from
Aug 25, 2026
Merged

🧹 [code health improvement description] Refactor Display formatters in token_kind.rs #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 3 additions & 27 deletions compiler/syntax/src/token_kind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,7 @@ pub enum LiteralKind {

impl fmt::Display for LiteralKind {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
let label = match self {
LiteralKind::Int => "Int",
LiteralKind::Float => "Float",
LiteralKind::Str => "Str",
LiteralKind::Bool => "Bool",
LiteralKind::Null => "Null",
};
write!(f, "{}", label)
fmt::Debug::fmt(self, f)
}
}

Expand All @@ -47,13 +40,7 @@ pub enum NumericLiteralKind {

impl fmt::Display for NumericLiteralKind {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
let label = match self {
NumericLiteralKind::Decimal => "Decimal",
NumericLiteralKind::Hex => "Hex",
NumericLiteralKind::Binary => "Binary",
NumericLiteralKind::Octal => "Octal",
};
write!(f, "{}", label)
fmt::Debug::fmt(self, f)
}
}

Expand Down Expand Up @@ -791,18 +778,7 @@ impl fmt::Display for TokenKind {
if let Some(lexeme) = self.static_lexeme() {
write!(f, "'{}'", lexeme)
} else {
let label = match self {
TokenKind::Identifier => "Identifier",
TokenKind::IntLiteral => "Integer Literal",
TokenKind::FloatLiteral => "Float Literal",
TokenKind::StringLiteral => "String Literal",
TokenKind::FStringText => "f-string segment",
TokenKind::Newline => "Newline",
TokenKind::Eof => "EOF",
TokenKind::Error => "Error",
_ => "Unknown Token",
};
write!(f, "{}", label)
fmt::Debug::fmt(self, f)
}
}
}
Expand Down
Loading