Skip to content

🔒 Fix SQL Injection vulnerability in std.sqlite module by supporting parameterized queries #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 1 commit into from
Aug 25, 2026
Merged

🔒 Fix SQL Injection vulnerability in std.sqlite module by supporting parameterized queries #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/llvm_backend/src/jit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#![cfg(feature = "llvm")]

use llvm_sys::core::*;
use llvm_sys::orc2::*;
use llvm_sys::orc2::lljit::*;
use llvm_sys::orc2::*;
use std::collections::HashMap;
use std::ffi::CString;
use std::ptr;
Expand Down Expand Up @@ -60,7 +60,7 @@ impl LLVMJitEngine {

// 3. Set host target triple
let _host_triple = LLVMOrcLLJITGetExecutionSession(self.jit); // session triple fallback
// We can just keep the default LLVM target triple
// We can just keep the default LLVM target triple

// 4. Wrap Module in ThreadSafeModule
let tsm = LLVMOrcCreateNewThreadSafeModule(ctx.module, self.ts_ctx);
Expand Down
61 changes: 59 additions & 2 deletions stdlib/src/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,39 @@ impl StdlibRegistry {
)
})?;
let sql = args[1].to_string();
let params_list = if args.len() > 2 {
if let RuntimeValue::List { items, .. } = &args[2] {
items.borrow().clone()
} else {
Vec::new()
}
} else {
Vec::new()
};

CONNECTIONS.with(|m| {
let mut map = m.borrow_mut();
if let Some(conn) = map.get_mut(&id) {
conn.execute(&sql, []).map_err(|e| {
let params_converted: Vec<rusqlite::types::Value> = params_list
.iter()
.map(|p| match p {
RuntimeValue::Null => rusqlite::types::Value::Null,
RuntimeValue::Bool(b) => {
rusqlite::types::Value::Integer(if *b { 1 } else { 0 })
}
RuntimeValue::Int(i) => rusqlite::types::Value::Integer(*i),
RuntimeValue::Float(f) => rusqlite::types::Value::Real(*f),
RuntimeValue::Str(s) => rusqlite::types::Value::Text(s.clone()),
_ => rusqlite::types::Value::Null,
})
.collect();

let params_refs: Vec<&dyn rusqlite::types::ToSql> = params_converted
.iter()
.map(|p| p as &dyn rusqlite::types::ToSql)
.collect();

conn.execute(&sql, params_refs.as_slice()).map_err(|e| {
RuntimeError::new(
RuntimeErrorKind::InvalidOperation(e.to_string()),
None,
Expand Down Expand Up @@ -93,6 +121,15 @@ impl StdlibRegistry {
)
})?;
let sql = args[1].to_string();
let params_list = if args.len() > 2 {
if let RuntimeValue::List { items, .. } = &args[2] {
items.borrow().clone()
} else {
Vec::new()
}
} else {
Vec::new()
};

let rows = CONNECTIONS.with(|m| {
let mut map = m.borrow_mut();
Expand All @@ -108,9 +145,29 @@ impl StdlibRegistry {
let col_names: Vec<String> = (0..col_count)
.map(|i| stmt.column_name(i).unwrap_or("?").to_string())
.collect();

let params_converted: Vec<rusqlite::types::Value> = params_list
.iter()
.map(|p| match p {
RuntimeValue::Null => rusqlite::types::Value::Null,
RuntimeValue::Bool(b) => {
rusqlite::types::Value::Integer(if *b { 1 } else { 0 })
}
RuntimeValue::Int(i) => rusqlite::types::Value::Integer(*i),
RuntimeValue::Float(f) => rusqlite::types::Value::Real(*f),
RuntimeValue::Str(s) => rusqlite::types::Value::Text(s.clone()),
_ => rusqlite::types::Value::Null,
})
.collect();

let params_refs: Vec<&dyn rusqlite::types::ToSql> = params_converted
.iter()
.map(|p| p as &dyn rusqlite::types::ToSql)
.collect();

let mut rows = Vec::new();
let row_iter = stmt
.query_map([], |row| {
.query_map(params_refs.as_slice(), |row| {
let mut map = IndexMap::new();
for i in 0..col_count {
let name = col_names[i].clone();
Expand Down
Loading