Repository navigation
feat(market): let market items declare credential authentication - #1072
Open
xunzhaoanan wants to merge 1 commit into
Open
xunzhaoanan wants to merge 1 commit into
xunzhaoanan wants to merge 1 commit into
Conversation
Completes #1033 for the market path: a market catalog entry with authType "credential" can now name its credentialKind, and installing it carries both onto the saved MCPServerDefinition. Without this, a credential-authenticated MCP could be defined but never delivered by the market.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #1033 for the market path.
Motivation
#1033 added credential-authenticated MCP servers (
authType: "credential"+credentialKind), but a market catalog entry cannot declare them:mcpMarketItemhas nocredentialKindfield andinstallMarketMCPdoes not carry it onto the saved definition. A credential-authenticated MCP can therefore be defined by hand but never delivered through the market.Changes
mcpMarketItem.CredentialKind(json:"credentialKind,omitempty") — names the credential bound as the Authorization Bearer header whenauthTypeis"credential"(same semantics asMCPServerDefinition.CredentialKind).installMarketMCPcarriesitem.CredentialKindonto the installedMCPServerDefinition.{ "id": "corp-gateway", "url": "https://gateway.internal/mcp", "transport": "http", "authType": "credential", "credentialKind": "corp-gateway" }Testing
TestMCPMarketInstallCarriesCredentialKind: a credential market item installs with bothauthTypeandcredentialKindintact.