Skip to content

feat(market): let market items declare credential authentication - #1072

Open
xunzhaoanan wants to merge 1 commit into
mainfrom
feat/market-credential-kind
Open

xunzhaoanan wants to merge 1 commit into
mainfrom
feat/market-credential-kind

Conversation

@xunzhaoanan

Copy link
Copy Markdown
Collaborator

Completes #1033 for the market path.

Motivation

#1033 added credential-authenticated MCP servers (authType: "credential" + credentialKind), but a market catalog entry cannot declare them: mcpMarketItem has no credentialKind field and installMarketMCP does not carry it onto the saved definition. A credential-authenticated MCP can therefore be defined by hand but never delivered through the market.

Changes

  • mcpMarketItem.CredentialKind (json:"credentialKind,omitempty") — names the credential bound as the Authorization Bearer header when authType is "credential" (same semantics as MCPServerDefinition.CredentialKind).
  • installMarketMCP carries item.CredentialKind onto the installed MCPServerDefinition.
{
  "id": "corp-gateway",
  "url": "https://gateway.internal/mcp",
  "transport": "http",
  "authType": "credential",
  "credentialKind": "corp-gateway"
}

Testing

  • TestMCPMarketInstallCarriesCredentialKind: a credential market item installs with both authType and credentialKind intact.
  • Full market test suite passes.

Completes #1033 for the market path: a market catalog entry with
authType "credential" can now name its credentialKind, and installing
it carries both onto the saved MCPServerDefinition. Without this, a
credential-authenticated MCP could be defined but never delivered by
the market.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants