Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/httpapi/mcp_market.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ type mcpMarketItem struct {
URL string `json:"url"`
Transport string `json:"transport"`
AuthType string `json:"authType"`
Official bool `json:"official"`
Aliases []string `json:"aliases,omitempty"`
// CredentialKind names the credential bound as the Authorization Bearer
// header when AuthType is "credential" (see MCPServerDefinition).
CredentialKind string `json:"credentialKind,omitempty"`
Official bool `json:"official"`
Aliases []string `json:"aliases,omitempty"`
}

type mcpMarketCatalogFile struct {
Expand Down Expand Up @@ -100,7 +103,7 @@ func installMarketMCP(st *repo.Store, marketID, projectID string) (domain.MCPSer
server := domain.MCPServerDefinition{
ID: mcpInstallID(item.ID, "project", projectID), MarketID: item.ID, Name: item.Name,
Description: item.Description, IconURL: item.IconURL, Transport: item.Transport,
URL: item.URL, AuthType: item.AuthType, Scope: "project", ProjectID: projectID,
URL: item.URL, AuthType: item.AuthType, CredentialKind: item.CredentialKind, Scope: "project", ProjectID: projectID,
TimeoutSec: 60, UpdatedAt: time.Now().UTC(),
}
if err := st.PutMCPServer(server); err != nil {
Expand Down
30 changes: 30 additions & 0 deletions internal/httpapi/mcp_market_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,3 +292,33 @@ func TestMCPMarketIconsAreLocalAndEmbedded(t *testing.T) {
t.Fatalf("expected local icons, got %d", withIcon)
}
}

func TestMCPMarketInstallCarriesCredentialKind(t *testing.T) {
st, err := repo.OpenTest()
if err != nil {
t.Fatal(err)
}
t.Cleanup(func() { st.Close() })
if err := st.PutProject(domain.Project{ID: "platform", Name: "Platform"}); err != nil {
t.Fatal(err)
}
// Register a credential-authenticated market item (package globals are
// the catalog seam); restore the real catalog afterwards.
previous := mcpMarketItems
mcpMarketItems = append(append([]mcpMarketItem(nil), previous...), mcpMarketItem{
ID: "corp-gateway", Name: "Corp Gateway", URL: "https://gateway.internal/mcp",
Transport: "http", AuthType: "credential", CredentialKind: "corp-gateway", Official: true,
})
t.Cleanup(func() { mcpMarketItems = previous })

server, created, err := installMarketMCP(st, "corp-gateway", "platform")
if err != nil || !created {
t.Fatalf("installMarketMCP = %v, %v", created, err)
}
if server.AuthType != "credential" || server.CredentialKind != "corp-gateway" {
t.Fatalf("installed server = %+v", server)
}
if server.Transport != "http" {
t.Fatalf("transport = %q", server.Transport)
}
}
Loading