Skip to content

Tighten the clock period for gt2n designs - #4570

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:tighten-gt2n
Sep 27, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:tighten-gt2n

Conversation

@maliberty

Copy link
Copy Markdown
Member

Produce negative slacks

Produce negative slacks

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Sep 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces the clock period (clk_period) in the SDC constraint files for the aes, gcd, and jpeg designs under the gt2n flow. However, the changes also removed helpful explanatory comments regarding the non-standard time unit (time_unit = 1 ps) and target frequencies. The reviewer recommends retaining and updating these comments to maintain readability and prevent confusion, as SDC files typically default to nanoseconds.

Comment thread flow/designs/gt2n/aes/constraint.sdc
Comment thread flow/designs/gt2n/gcd/constraint.sdc
Comment thread flow/designs/gt2n/jpeg/constraint.sdc
@maliberty
maliberty merged commit 25b6429 into The-OpenROAD-Project:master Sep 27, 2026
10 of 12 checks passed
@maliberty
maliberty deleted the tighten-gt2n branch September 27, 2026 18:19
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 512b8b0 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 2 with regression(s), 0 without a comparable baseline.

❌ gt2n/gcd base — 7 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -786.696 0 — -100.0 PeriodPadding 20%
cts__timing__setup__ws -62.9036 158.356 -139.72290282654274% -25.0 PeriodPadding 5%
finish__timing__setup__tns -1187.76 0 — -100.0 PeriodPadding 20%
finish__timing__setup__ws -68.8317 150.061 -145.86914654707087% -25.0 PeriodPadding 5%
globalroute__timing__setup__tns -1187.75 0 — -100.0 PeriodPadding 20%
globalroute__timing__setup__ws -68.8299 150.061 -145.8679470348725% -25.0 PeriodPadding 5%
placeopt__design__instance__area 21.5127 18.5432 16.013956598645326% 21.32468 Padding 15%
❌ gt2n/jpeg base — 4 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -15681.9 0 — -200.0 PeriodPadding 20%
cts__timing__setup__ws -60.0663 131.953 -145.52098095534015% -50.0 PeriodPadding 5%
finish__timing__setup__tns -4650.05 0 — -200.0 PeriodPadding 20%
globalroute__timing__setup__tns -4617.66 0 — -200.0 PeriodPadding 20%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants