Conversation
Produce negative slacks Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request reduces the clock period (clk_period) in the SDC constraint files for the aes, gcd, and jpeg designs under the gt2n flow. However, the changes also removed helpful explanatory comments regarding the non-standard time unit (time_unit = 1 ps) and target frequencies. The reviewer recommends retaining and updating these comments to maintain readability and prevent confusion, as SDC files typically default to nanoseconds.
maliberty
merged commit Sep 27, 2026
25b6429
into
The-OpenROAD-Project:master
10 of 12 checks passed
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 2 with regression(s), 0 without a comparable baseline. ❌ gt2n/gcd base — 7 failing metric(s)
❌ gt2n/jpeg base — 4 failing metric(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Produce negative slacks