Conversation
These designs finish without the flag (detailed routing completes, DRC 0) but lose some setup timing, so the QoR dashboard rules need updating. See The-OpenROAD-Project#4575 for the history of the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the REMOVE_ABC_BUFFERS configuration variable from several design configuration files, including ihp-sg13g2/aes, sky130hd/riscv32i, and sky130hs/riscv32i. No review comments were provided, and there is no additional feedback to address.
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Sep 29, 2026
floorplan.tcl now always runs repair_timing_helper. The variable is dropped from variables.yaml, variables.json and FlowVariables.md. Designs are deliberately not touched here; they are handled by The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 3 with regression(s), 0 without a comparable baseline. ❌ ihp-sg13g2/aes base — 1 failing metric(s)
❌ sky130hd/riscv32i base — 1 failing metric(s)
❌ sky130hs/riscv32i base — 1 failing metric(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4575, which has the background:
REMOVE_ABC_BUFFERS=1dates from the full floorplanrepair_timingin 2024, and is no longer needed to get through routing.These three designs finish without the flag, with detailed routing completing and DRC 0, but they lose some setup timing:
REMOVE_ABC_BUFFERS=0), both checked against the dashboard'sbasemaster baseline.bazelisk run //:install(bazel: //:install also installs yosys for ORFS OpenROAD#11563). This is newer than the ORFS pin, so CI's numbers will differ somewhat.Expected CI result: the QoR check fails on these designs until the rules are updated.
Ask for maintainers: if the trade-off is acceptable, please update the dashboard rules/baseline for these designs from this PR's CI metadata. If any of them should keep the flag, say which and I'll drop it from this PR.
🤖 Generated with Claude Code