Conversation
The flag was added in e00e293 to get the design through in a reasonable time. Runtime is now the same with or without it, but QoR differs, and the dashboard baseline already fails with current tools, so this needs a maintainer's judgement. See The-OpenROAD-Project#4575 for the history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Sep 29, 2026
floorplan.tcl now always runs repair_timing_helper. The variable is dropped from variables.yaml, variables.json and FlowVariables.md. Designs are deliberately not touched here; they are handled by The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 36 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4575, which has the background on
REMOVE_ABC_BUFFERS. This design gets its own PR because it's different from the others: it already fails the dashboard QoR check with the flag set, using current tools.REMOVE_ABC_BUFFERS=0)bazelisk run //:install(bazel: //:install also installs yosys for ORFS OpenROAD#11563). This is newer than the ORFS pin, so CI's numbers will differ.Ask for maintainers:
🤖 Generated with Claude Code