Skip to content

Drop REMOVE_ABC_BUFFERS from ihp-sg13g2/jpeg (needs judgement) - #4577

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-abc-buffers-ihp-jpeg
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-abc-buffers-ihp-jpeg

Conversation

@oharboe

@oharboe oharboe commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #4575, which has the background on REMOVE_ABC_BUFFERS. This design gets its own PR because it's different from the others: it already fails the dashboard QoR check with the flag set, using current tools.

  • Why the flag was added: e00e293, "to get ihp-sg13g2 jpeg to pass in a reasonable time". Runtime is now about the same either way (~140 min locally), so that reason is gone.
  • Routing: detailed routing completes and DRC is 0, with and without the flag.
dashboard check failing rules
before (flag set) FAIL, 5 rules cts setup ws 0.936 → -0.542, cts/finish/grt setup tns, stdcell count +16% vs baseline
after (REMOVE_ABC_BUFFERS=0) FAIL, 7 rules as above, plus finish ws -0.619 and grt ws -0.856; finish tns -13.1

Ask for maintainers:

  • The baseline (setup ws +0.94, 76k stdcells) doesn't look reachable with current tools, whether or not the flag is set. It may need a look independently of this PR.
  • Then decide whether to drop the flag and re-baseline, or keep it.

🤖 Generated with Claude Code

The flag was added in e00e293 to get the design through in a
reasonable time. Runtime is now the same with or without it, but QoR
differs, and the dashboard baseline already fails with current tools,
so this needs a maintainer's judgement. See The-OpenROAD-Project#4575 for the history.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the export of the REMOVE_ABC_BUFFERS environment variable from the JPEG design configuration file. There are no review comments, and I have no feedback to provide.

@oharboe
oharboe requested a review from maliberty September 29, 2026 05:31
oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request Sep 29, 2026
floorplan.tcl now always runs repair_timing_helper. The variable is
dropped from variables.yaml, variables.json and FlowVariables.md.

Designs are deliberately not touched here; they are handled by
The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 967aaf7 · Jenkins build #1 · Baseline: build · View build on dashboard

36 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants