Drop REMOVE_ABC_BUFFERS from sky130hd/ibex and sky130hs/ibex (CI to judge) - #4578
Merged
maliberty merged 1 commit intoSep 30, 2026
Merged
Conversation
Not checked locally: both use the slang frontend. CI will show whether they still need the flag. See The-OpenROAD-Project#4575 for the history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Sep 29, 2026
floorplan.tcl now always runs repair_timing_helper. The variable is dropped from variables.yaml, variables.json and FlowVariables.md. Designs are deliberately not touched here; they are handled by The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Collaborator
Author
|
@vvbandeira pr-head CI outage. |
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4575, which has the background on
REMOVE_ABC_BUFFERS: it dates from the full floorplanrepair_timingin 2024, and other designs no longer need it to get through routing.SYNTH_HDL_FRONTEND=slang, and the yosys I tested with (BCR yosys viabazelisk run //:install, bazel: //:install also installs yosys for ORFS OpenROAD#11563) has no slang frontend yet. This PR lets CI produce the numbers.Ask for maintainers: please look at CI's result for these two designs.
🤖 Generated with Claude Code