Conversation
Users are more likely to copy and modify the existing design closest to their own problem than to start from a generic "minimal" template. Unused examples dilute the clarity of the documentation and designs. test_outoftree.sh was added alongside minimal (PR The-OpenROAD-Project#2807) to smoke-test running minimal's config.mk from outside the ORFS tree. It was never wired into CI or Jenkins and depends on minimal, so it goes too. The screening build advice in LargeDesigns.md is kept, without the links to minimal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the "minimal" design configuration, including its configuration files, smoke-test script, and associated documentation. References to this minimal configuration are also cleaned up in README.md and docs/user/LargeDesigns.md. The review feedback suggests a minor rephrasing in docs/user/LargeDesigns.md to improve clarity regarding configuration options.
The "screening build" framing motivated the now removed asap7/minimal design. Refocus the section on the page's topic, finding memories that were translated to flip flops, and keep the variable tips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
maliberty
approved these changes
Sep 29, 2026
maliberty
enabled auto-merge
September 29, 2026 13:52
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 33 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR almost certainly unused cruft that dilutes the manuals clarity. Seemed like a good idea at the time, never used it. Certainly irrelevant now with AI.
...
Users are more likely to copy and modify the existing design closest to their own problem than to start from a generic "minimal" template. Unused examples dilute the clarity of the documentation and designs.
flow/designs/asap7/minimal/(README, config.mk, empty.sdc, ~2.5 MB of screenshots).flow/test/test_outoftree.sh. It was added with minimal in designs/asap7/minimal: getting started README.md #2807 to smoke-test minimal's config.mk from outside the tree. It was never wired into CI or Jenkins, and it depends on minimal.README.md: drop the "Running a quick smoke-test of ORFS on your own Verilog" section. "Building from your own git repository" still covers out-of-tree use.docs/user/LargeDesigns.md: drop the links to minimal and the "screening build" narrative that motivated it. The section now covers finding memories translated to flip flops, and the variable tips are kept.git grep "asap7/minimal\|outoftree"finds no remaining references.🤖 Generated with Claude Code