Skip to content

Bump OpenROAD and use the OpenSTA scene API for corners - #4839

Open
dsengupta0628 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-or_update_sta_scene_api
Open

dsengupta0628 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-or_update_sta_scene_api

Conversation

@dsengupta0628

Copy link
Copy Markdown
Contributor

Summary

Bumps OpenROAD to pick up the OpenSTA scene API (OpenROAD PR The-OpenROAD-Project/OpenROAD#12313 that bumps sta pointer brought over by PR The-OpenROAD-Project/OpenSTA#476) and migrates the flow scripts off the removed define_corners / read_liberty -corner.

Changes

  • flow/scripts/read_liberty.tcl: with CORNERS, each liberty file is read once and bound to its corner's scene with define_scene <corner> -liberty .... The first corner remains the command scene, as define_corners left it. AUTO_MEMORIES views are read once and added to every corner's scene. The no-corner path is unchanged.
  • flow/scripts/report_metrics.tcl: report_power -scene, report_power_metric -scene (OpenSTA dropped -corner; OpenROAD's report_power_metric -corner is deprecated with a warning).

Testing

  • tclfmt / tclint clean.
  • read_liberty.tcl run standalone with CORNERS="slow fast" on ihp-sg13g2 libs: libraries read once, two scenes defined, command scene slow, no warnings.
  • Multi-corner designs to watch in CI: ihp-sg13g2/i2c-gpio-expander (CORNERS = slow fast) and its I2cDeviceCtrl (slow typ fast).

OpenROAD now carries OpenSTA master, which removed define_corners and
read_liberty -corner. Libraries are read once and bound to a scene per
corner with define_scene -liberty; the first corner stays the command
scene as define_corners left it. AUTO_MEMORIES views are read once and
added to every corner's scene.

report_power and report_power_metric take -scene.

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 self-assigned this Nov 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the liberty reading process in read_liberty.tcl to read each unique library once and bind them to corners using define_scene, while also updating report_metrics.tcl to use -scene instead of -corner and updating the OpenROAD submodule. The review feedback recommends initializing the corner_libs dictionary with empty lists for all corners to avoid Tcl dictionary key errors and ensure clearer downstream error handling if a corner has no libraries defined.

Comment on lines +6 to +7
set corner_libs [dict create]
set read_libs {}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential Tcl dictionary key errors (e.g., key not known in dictionary) if a corner has no libraries defined in its CORNER_LIB_FILES and there are no auto memories, it is safer to initialize corner_libs with empty lists for all defined corners. This ensures that dict get always succeeds, and any missing library configuration will be caught with a clearer error message by the downstream define_scene command.

  set corner_libs [dict create]\n  foreach corner $::env(CORNERS) {\n    dict set corner_libs $corner {}\n  }\n  set read_libs {}

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit ff7cd89 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 9 with regression(s), 0 without a comparable baseline.

❌ asap7/aes_lvt base — 2 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -308.327 -23.411 -1217.040% -85.411 PeriodPadding 20.000%
finish__timing__setup__ws -23.251 -3.471 -569.789% -18.971 PeriodPadding 5.000%
❌ asap7/ibex base — 2 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -5530.900 -1292.350 -327.972% -1550.820 PeriodPadding 20.000%
globalroute__timing__setup__tns -11046.800 -7279.810 -51.746% -8735.772 PeriodPadding 20.000%
❌ asap7/riscv32i base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -4690.630 -1067.860 -339.255% -1281.432 PeriodPadding 20.000%
❌ nangate45/swerv_wrapper base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -278.638 -219.752 -26.797% -263.702 PeriodPadding 20.000%
❌ sky130hd/chameleon base — 2 failing metric(s)
Metric target base delta limit band
detailedroute__antenna_diodes_count 110.000 82.000 34.146% 100.000 Metric 0.100%
globalroute__timing__setup__tns -2.096 -0.976 -114.700% -1.576 PeriodPadding 20.000%
❌ sky130hd/gcd base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__ws -1.278 -1.196 -6.867% -1.256 PeriodPadding 5.000%
❌ sky130hd/microwatt base — 2 failing metric(s)
Metric target base delta limit band
detailedroute__antenna__violating__nets 5.000 3.000 66.667% 3.900 Padding 30.000%
detailedroute__antenna_diodes_count 2332.000 1951.000 19.528% 1952.951 Metric 0.100%
❌ sky130hs/ibex base — 1 failing metric(s)
Metric target base delta limit band
globalroute__timing__setup__tns -20.832 -12.334 -68.900% -14.800 PeriodPadding 20.000%
❌ sky130hs/riscv32i base — 2 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -12.194 -2.838 -329.692% -3.638 PeriodPadding 20.000%
globalroute__timing__setup__tns -64.656 -51.125 -26.467% -61.350 PeriodPadding 20.000%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants