Repository navigation
Bump OpenROAD and use the OpenSTA scene API for corners - #4839
dsengupta0628 wants to merge 1 commit into
Conversation
OpenROAD now carries OpenSTA master, which removed define_corners and read_liberty -corner. Libraries are read once and bound to a scene per corner with define_scene -liberty; the first corner stays the command scene as define_corners left it. AUTO_MEMORIES views are read once and added to every corner's scene. report_power and report_power_metric take -scene. Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates the liberty reading process in read_liberty.tcl to read each unique library once and bind them to corners using define_scene, while also updating report_metrics.tcl to use -scene instead of -corner and updating the OpenROAD submodule. The review feedback recommends initializing the corner_libs dictionary with empty lists for all corners to avoid Tcl dictionary key errors and ensure clearer downstream error handling if a corner has no libraries defined.
| set corner_libs [dict create] | ||
| set read_libs {} |
There was a problem hiding this comment.
To prevent potential Tcl dictionary key errors (e.g., key not known in dictionary) if a corner has no libraries defined in its CORNER_LIB_FILES and there are no auto memories, it is safer to initialize corner_libs with empty lists for all defined corners. This ensures that dict get always succeeds, and any missing library configuration will be caught with a clearer error message by the downstream define_scene command.
set corner_libs [dict create]\n foreach corner $::env(CORNERS) {\n dict set corner_libs $corner {}\n }\n set read_libs {}
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 9 with regression(s), 0 without a comparable baseline. ❌ asap7/aes_lvt base — 2 failing metric(s)
❌ asap7/ibex base — 2 failing metric(s)
❌ asap7/riscv32i base — 1 failing metric(s)
❌ nangate45/swerv_wrapper base — 1 failing metric(s)
❌ sky130hd/chameleon base — 2 failing metric(s)
❌ sky130hd/gcd base — 1 failing metric(s)
❌ sky130hd/microwatt base — 2 failing metric(s)
❌ sky130hs/ibex base — 1 failing metric(s)
❌ sky130hs/riscv32i base — 2 failing metric(s)
|
Summary
Bumps OpenROAD to pick up the OpenSTA scene API (OpenROAD PR The-OpenROAD-Project/OpenROAD#12313 that bumps sta pointer brought over by PR The-OpenROAD-Project/OpenSTA#476) and migrates the flow scripts off the removed
define_corners/read_liberty -corner.Changes
flow/scripts/read_liberty.tcl: withCORNERS, each liberty file is read once and bound to its corner's scene withdefine_scene <corner> -liberty .... The first corner remains the command scene, asdefine_cornersleft it. AUTO_MEMORIES views are read once and added to every corner's scene. The no-corner path is unchanged.flow/scripts/report_metrics.tcl:report_power -scene,report_power_metric -scene(OpenSTA dropped-corner; OpenROAD'sreport_power_metric -corneris deprecated with a warning).Testing
tclfmt/tclintclean.read_liberty.tclrun standalone withCORNERS="slow fast"on ihp-sg13g2 libs: libraries read once, two scenes defined, command sceneslow, no warnings.ihp-sg13g2/i2c-gpio-expander(CORNERS = slow fast) and itsI2cDeviceCtrl(slow typ fast).