Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions flow/scripts/read_liberty.tcl
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
#Read Liberty
# With corners, every library is read once and then bound to the scene of
# each corner that lists it. define_scene resolves a library by the
# filename read_liberty was given.
if { [env_var_exists_and_non_empty CORNERS] } {
# corners
define_corners {*}$::env(CORNERS)
set corner_libs [dict create]
set read_libs {}
Comment on lines +6 to +7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential Tcl dictionary key errors (e.g., key not known in dictionary) if a corner has no libraries defined in its CORNER_LIB_FILES and there are no auto memories, it is safer to initialize corner_libs with empty lists for all defined corners. This ensures that dict get always succeeds, and any missing library configuration will be caught with a clearer error message by the downstream define_scene command.

  set corner_libs [dict create]\n  foreach corner $::env(CORNERS) {\n    dict set corner_libs $corner {}\n  }\n  set read_libs {}

foreach corner $::env(CORNERS) {
set LIBKEY "[string toupper $corner]_LIB_FILES"
foreach libFile $::env($LIBKEY) {
log_cmd read_liberty -corner $corner [lib_file_to_read $libFile]
set lib [lib_file_to_read $libFile]
if { $lib ni $read_libs } {
log_cmd read_liberty $lib
lappend read_libs $lib
}
dict lappend corner_libs $corner $lib
}
unset LIBKEY
}
Expand All @@ -22,11 +30,19 @@ if { [env_var_exists_and_non_empty CORNERS] } {
# _pre_layout variants (ideal clock) are for pre-CTS consumers that
# select lib files themselves.
foreach libFile [auto_memories_views .lib] {
log_cmd read_liberty $libFile
if { [env_var_exists_and_non_empty CORNERS] } {
foreach corner $::env(CORNERS) {
log_cmd read_liberty -corner $corner $libFile
dict lappend corner_libs $corner $libFile
}
} else {
log_cmd read_liberty $libFile
}
}

if { [env_var_exists_and_non_empty CORNERS] } {
foreach corner $::env(CORNERS) {
log_cmd define_scene $corner -liberty [dict get $corner_libs $corner]
}
# The first corner is the command scene, as define_corners left it.
log_cmd set_scene [lindex $::env(CORNERS) 0]
unset corner corner_libs read_libs
}
4 changes: 2 additions & 2 deletions flow/scripts/report_metrics.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ proc report_metrics { stage when { include_erc true } { include_clock_skew true
if { [env_var_exists_and_non_empty CORNERS] } {
foreach corner $::env(CORNERS) {
report_puts "Corner: $corner"
report_power -corner $corner >> $filename
report_power_metric -corner $corner
report_power -scene $corner >> $filename
report_power_metric -scene $corner
}
unset corner
} else {
Expand Down
2 changes: 1 addition & 1 deletion tools/OpenROAD
Submodule OpenROAD updated 506 files