Max health depends on veterancy and upgrade order

[tintinhamans]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

An object's final maximum health can differ depending on whether a fixed MaxHealthUpgrade is applied before or after it gains veterancy.

As far as I know the following are affected:

• Upgrade_AmericaCompositeArmor
• Upgrade_AmericaDroneArmor
• Upgrade_ChinaAircraftArmor

For example, in Zero Hour 1.04, a Paladin has 500 base health, Composite Armor adds +100 health, and Elite veterancy applies a 130% health multiplier:

• Composite Armor first, then Elite: (500 + 100) × 1.3 = 780
• Elite first, then Composite Armor: (500 × 1.3) + 100 = 750

The unit has the same visible state to the player (Elite veterancy and Composite Armor) but differs by 30 HP only because of the order of events.