bugfix(pathfinder): Restore retail compatibility after crash fix changes to Pathfinder::findAttackPath

[Caball009]

• Follow-up for bugfix(pathfinder): Fix various crashes in Pathfinder due to inadequate cleanup of pathfinding resources #994

#994 introduced a minor Generals specific mistake that causes some replays to mismatch. Here's one such replay: replay.zip

---

Original code:

GeneralsGameCode/Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Lines 10079 to 10084 in 783bdb7

	Path *path = buildActualPath( obj, locomotorSet.getValidSurfaces(), obj->getPosition(), parentCell, centerInCell, false);
	parentCell->releaseInfo();
	if (goalCell->hasInfo() && !goalCell->getClosed() && !goalCell->getOpen()) {
	goalCell->releaseInfo();
	}
	cleanOpenAndClosedLists();

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Lines 10787 to 10791 in 783bdb7

	Path *path = buildActualPath( obj, locomotorSet.getValidSurfaces(), obj->getPosition(), parentCell, centerInCell, false);
	if (goalCell->hasInfo() && !goalCell->getClosed() && !goalCell->getOpen()) {
	goalCell->releaseInfo();
	}
	cleanOpenAndClosedLists();

Notice how only the Generals code contains parentCell->releaseInfo().

Current code:

GeneralsGameCode/Core/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Lines 11021 to 11030 in a2cffe4

	Path *path = buildActualPath( obj, locomotorSet.getValidSurfaces(), obj->getPosition(), parentCell, centerInCell, false);
	#if RETAIL_COMPATIBLE_PATHFINDING
	if (!s_useFixedPathfinding) {
	if (goalCell->hasInfo() && !goalCell->getClosed() && !goalCell->getOpen()) {
	goalCell->releaseInfo();
	}
	cleanOpenAndClosedLists();
	}
	else
	#endif

The current (retail compatible) code doesn't have parentCell->releaseInfo(), even though it should for Generals.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Restore Generals retail-compatible attack path cleanup

🐞 Bug fix 🕐 Less than 10 minutes

AI Description

• Restores Generals-specific parent-cell cleanup in retail-compatible attack pathfinding.
• Preserves Zero Hour behavior while preventing Generals replay mismatches.

Diagram

graph TD
  A["Find attack path"] --> B{"Retail mode?"} -->|Legacy| C{"Generals build?"} -->|Yes| D["Release parent info"] --> E["Release goal info"] --> F["Clean path lists"]
  C -->|No| E
  B -->|Fixed| F

Loading

High-Level Assessment

The compile-time RTS_GENERALS guard is the appropriate approach because it precisely restores the original Generals-only cleanup semantics without changing Zero Hour behavior. Unconditional release or runtime title detection would broaden the behavioral change unnecessarily.

Files changed (1) +4 / -0

Bug fix (1) +4 / -0

AIPathfind.cppRestore Generals parent-cell cleanup in legacy pathfinding +4/-0

Restore Generals parent-cell cleanup in legacy pathfinding

• Releases parent-cell pathfinding information when using retail-compatible pathfinding in Generals builds. The RTS_GENERALS guard preserves the distinct Zero Hour cleanup behavior and restores replay compatibility.

Core/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[greptile-apps]

Greptile Summary

This PR restores the original Generals-specific cleanup behavior in Pathfinder::findAttackPath.

• Releases the successful search’s parent-cell information in retail-compatible Generals pathfinding mode.
• Leaves Zero Hour and fixed-pathfinding behavior unchanged.
• Preserves safe cleanup ordering because the parent cell is no longer linked into the open or closed lists at this point.

Confidence Score: 5/5

The PR appears safe to merge and correctly scopes the compatibility restoration to Generals retail pathfinding.

The new release operates on an unlinked parent cell, handles possible goal-cell aliasing safely through the existing information check, and does not alter Zero Hour or fixed-pathfinding execution.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameLogic/AI/AIPathfind.cpp	Adds the missing Generals-only parent-cell information release to the retail-compatible attack-path success branch.

_{Reviews (1): Last reviewed commit: "bugfix(pathfinder): Restore Generals ret..." | Re-trigger Greptile}

[Mauller]

Is good, already gone over this with @Caball009