Repository navigation
Conversation
The research preset turned off DoT blocking. With Android's Private DNS on "Automatic", Android then upgrades to DoT against the resolvers the VPN advertises, TrackerControl sees no plaintext DNS, and nothing is blocked in any mode while SNI still records trackers as allowed (#968). - Keep "Block Android's Private DNS" on in every onboarding preset. - Warn when Private DNS is active on the VPN network (LinkProperties.isPrivateDnsActive), without needing the full traffic log. Re-check 30 s after the VPN comes up and after block_dot changes, since Android validates DoT asynchronously. - In SNI attribution, store the tracker name that matched (the CNAME target for cloaked trackers) so the timeline and Protection screen find the row again, and keep the shared-IP mark that explains why standard mode allowed the contact. Claude-Session: https://claude.ai/code/session_01WgbtBAKqNxgmeXSPtUoXxp
kasnder
marked this pull request as ready for review
October 8, 2026 14:32
kasnder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research mode disables tracker blocking even when Strict mode and per-tracker blocking rules are selected. In #968, the attached settings have
log_logcat=true: the statistics report allowed connections while Manage App displays the saved blocking rules. The previous transient warning was easy to miss.This PR adds a persistent notice above the Timeline, Apps, and VPN tabs: “Research mode is on. Tracker blocking is disabled. Tap to change settings.” Tapping opens Settings, and the notice disappears when Research is disabled. The Research preference description also explicitly states that blocking is disabled. Research mode's blocking behaviour is unchanged.
The PR also retains these separate reporting improvements:
These DNS changes are not the diagnosis of #968: the reporter already had
block_dot=trueand Secure DNS enabled. The notice addresses the confusion; per-tracker labels still represent saved rules.Validation:
The existing master correction for stale DDG test fixtures is included.