FIX: Inset the Supported Devices list in Input System settings so it aligns with the other fields [UUM-150207] - #2477
Merged
Conversation
…aligns with the other fields [UUM-150207] The "Supported Devices" ReorderableList in the Input System Package Settings sat flush against the panel edge with no left/right margin, while the surrounding EditorGUILayout fields were inset. In InputSettingsProvider.OnGUI(string searchContext), the bare m_SupportedDevices.DoLayoutList() call is now wrapped in an EditorGUILayout.HorizontalScope with a 3px GUILayout.Space on each side and the list placed in a VerticalScope so it expands to the remaining width, giving the list the same horizontal inset as the neighbouring controls. Jira: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150207
Pauliusd01
marked this pull request as ready for review
August 19, 2026 12:04
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The IMGUI scope change cleanly constrains the supported-device list to the intended inset while preserving the surrounding layout flow; I also examined the list initialization and changelog update.
Reviewed commit 49022dd
🤖 Helpful? 👍/👎
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2477 +/- ##
=========================================
Coverage 78.95% 78.96%
=========================================
Files 767 767
Lines 140780 140903 +123
=========================================
+ Hits 111153 111263 +110
- Misses 29627 29640 +13 Flags with carried forward coverage won't be shown. Click here to find out more.
|
VeraMommersteeg
approved these changes
Aug 19, 2026
VeraMommersteeg
left a comment
VeraMommersteeg
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, ty for fixing this small artifact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This pull request was generated automatically. Please review carefully before merging.
In
InputSettingsProvider.OnGUI(string searchContext), the "Supported Devices" list is drawn by aReorderableListviam_SupportedDevices.DoLayoutList(), which reserves a full-width rect and draws its header, elements and background box flush against the settings panel's content edge. As a result that section had no visible left/right margin while every surroundingEditorGUILayoutfield appeared inset, making the list look misaligned.The
DoLayoutList()call is now wrapped in anEditorGUILayout.HorizontalScopewith a 3pxGUILayout.Spaceon each side, and the list itself placed in anEditorGUILayout.VerticalScopeso it expands to the remaining width. This gives the list the same horizontal inset as the neighbouring controls without changing how the list itself behaves.Testing status & QA
InputTestFixture; it was verified by eyeballing the section in the running editor.Overall Product Risks
Comments to reviewers
N/A
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.