refactor: drop the reviewer rotation and rely on CODEOWNERS - #5
Merged
Merged
Conversation
Contributor
octoDNS planThis pull request changes no DNS records. Planned against |
jaspermayone
force-pushed
the
jaspermayone/reviewer-team-request
branch
from
September 21, 2026 19:58
1c1fc0b to
99f83f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
assign-reviewer.ymland.github/dns-reviewers.txt. The DNS Managers team is asked on every pull request byCODEOWNERS, which is what actually gates the merge.Why the rotation was not earning its keep
I built it to work around the free plan not having native team review assignment. Then two things came out:
The team gets asked either way.
CODEOWNERSmakes the team a required reviewer and GitHub will not let that request be dropped. I tried:DELETE /pulls/{n}/requested_reviewerswith onlyteam_reviewersreturns 422 ("reviewers" wasn't supplied), and with the correct{"reviewers":[],"team_reviewers":[...]}payload it returns 200 and changes nothing. So the rotation could only ever add a second notification, never replace the first.It was 90 lines of shell doing modular arithmetic over a text file that had to be kept in sync with team membership by hand. Two sources of truth for one question.
What changes in practice
Nothing about enforcement.
require_code_owner_reviewplusCODEOWNERSis what blocks the merge, and that is untouched.pick the next reviewerwas never a required check, so the ruleset needs no change.What you lose is a named assignee. With two people that mostly means a pull request can sit while each of you assumes the other has it.
CONTRIBUTING.mdnow says to speak up on the pull request when you pick one up or cannot get to it.Adding a reviewer is now one step: add them to the team.
Note on merge order
This and #6 both touch
docs/runbook.md, in different sections. Whichever lands second may want a rebase.