Skip to content

refactor: drop the reviewer rotation and rely on CODEOWNERS - #5

Merged
jaspermayone merged 1 commit into
mainfrom
jaspermayone/reviewer-team-request
Sep 21, 2026
Merged

jaspermayone merged 1 commit into
mainfrom
jaspermayone/reviewer-team-request

Conversation

@jaspermayone

@jaspermayone jaspermayone commented Sep 21, 2026

Copy link
Copy Markdown
Member

Removes assign-reviewer.yml and .github/dns-reviewers.txt. The DNS Managers team is asked on every pull request by CODEOWNERS, which is what actually gates the merge.

Why the rotation was not earning its keep

I built it to work around the free plan not having native team review assignment. Then two things came out:

The team gets asked either way. CODEOWNERS makes the team a required reviewer and GitHub will not let that request be dropped. I tried: DELETE /pulls/{n}/requested_reviewers with only team_reviewers returns 422 ("reviewers" wasn't supplied), and with the correct {"reviewers":[],"team_reviewers":[...]} payload it returns 200 and changes nothing. So the rotation could only ever add a second notification, never replace the first.

It was 90 lines of shell doing modular arithmetic over a text file that had to be kept in sync with team membership by hand. Two sources of truth for one question.

What changes in practice

Nothing about enforcement. require_code_owner_review plus CODEOWNERS is what blocks the merge, and that is untouched. pick the next reviewer was never a required check, so the ruleset needs no change.

What you lose is a named assignee. With two people that mostly means a pull request can sit while each of you assumes the other has it. CONTRIBUTING.md now says to speak up on the pull request when you pick one up or cannot get to it.

Adding a reviewer is now one step: add them to the team.

Note on merge order

This and #6 both touch docs/runbook.md, in different sections. Whichever lands second may want a rebase.

@jaspermayone
jaspermayone requested a review from a team as a code owner September 21, 2026 19:53
@github-actions
github-actions Bot requested a review from Cattn September 21, 2026 19:53
@github-actions

Copy link
Copy Markdown
Contributor

octoDNS plan

This pull request changes no DNS records.


Planned against main with a read-only Cloudflare token. Only the zone files at the repository root are included. Changes to config/, bin/ or .github/ are not in this plan, so review those by hand.

@jaspermayone jaspermayone changed the title fix: stop trying to remove a review request github will not remove refactor: drop the reviewer rotation and rely on CODEOWNERS Sep 21, 2026
@jaspermayone
jaspermayone force-pushed the jaspermayone/reviewer-team-request branch from 1c1fc0b to 99f83f6 Compare September 21, 2026 19:58
@jaspermayone
jaspermayone merged commit 99c729b into main Sep 21, 2026
5 checks passed
@jaspermayone
jaspermayone deleted the jaspermayone/reviewer-team-request branch September 21, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants