Repository navigation
Tests: Make data providers in filters.php static - #14790
Draft
shail-mehta wants to merge 1 commit into
Draft
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Both providers return literal arrays without instance dependencies, so these declaration-only changes preserve behavior.
No open issues 🎉
What changed in this PR
Makes two filter-test data providers static to align with current PHPUnit usage in WordPress Core. This is a test-only change with no production impact.
Changes:
- Converts the integer and non-integer priority data providers to
public static, preserving their data and existing test references.
| File | Description |
|---|---|
tests/phpunit/tests/filters.php |
Makes both priority callback order data providers static. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trac ticket: #65819
Makes the data providers in
tests/phpunit/tests/filters.phpstatic.Why
PHPUnit data providers should be static so they do not depend on test instance state and remain compatible with current PHPUnit usage in Core.
How
data_priority_callback_order_with_integers()topublic staticdata_priority_callback_order_with_unhappy_path_nonintegers()topublic staticTest-only; no production code changes.
Testing Instructions
npm run test:php -- --filter Tests_Filtersnpm run test:php -- --filter Tests_Filters -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Filters --order-by=randomUse of AI Tools