Skip to content

Tests: Make data providers in filters.php static #14790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shail-mehta wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Tests: Make data providers in filters.php static #14790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/phpunit/tests/filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function test_priority_callback_order( $priorities, $expected_call_order,
*
* @return array[]
*/
public function data_priority_callback_order_with_integers() {
public static function data_priority_callback_order_with_integers() {
return array(
'int DESC' => array(
'priorities' => array( 10, 9 ),
Expand All @@ -199,7 +199,7 @@ public function data_priority_callback_order_with_integers() {
*
* @return array[]
*/
public function data_priority_callback_order_with_unhappy_path_nonintegers() {
public static function data_priority_callback_order_with_unhappy_path_nonintegers() {
return array(
// Numbers as strings and floats.
'int as string DESC' => array(
Expand Down
Loading