[shail-mehta]

What

Trac ticket: #65819

Makes the data providers in tests/phpunit/tests/canonical.php static.

Why

PHPUnit data providers should be static so they do not depend on test instance state and remain compatible with current PHPUnit usage in Core.

How

• Convert data_canonical() to public static
• Convert data_redirect_guess_404_permalink_with_custom_statuses() to public static
• Convert data_redirect_guess_404_permalink_post_types() to public static
• Convert data_canonical_attachment_page_redirect_with_option_disabled() to public static

Test-only; no production code changes.

Testing Instructions

1. npm run test:php -- --filter Tests_Canonical
2. npm run test:php -- --filter Tests_Canonical -c tests/phpunit/multisite.xml
3. npm run test:php -- --filter Tests_Canonical --order-by=random
4. npm run test:php -- --group canonical

Use of AI Tools

• Cursor

[Copilot]

🟢 Approval recommended

The changes are limited to instance-independent data providers, with no compatibility conflicts or blocking issues identified.

No open issues 🎉

What changed in this PR

Updates the canonical URL tests to use static PHPUnit data providers, improving compatibility without changing test datasets or production code.

Changes:

• Adds static to all four specified data provider methods.
• Preserves existing test behavior; the providers have no instance dependencies.

File	Description
tests/​phpunit/​tests/​canonical.php	Converts four canonical and redirect data providers to static methods.

_{Review effort: Balanced}