Skip to content

Tests: Make data providers in canonical.php static #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shail-mehta wants to merge 1 commit into
base: trunk
Choose a base branch
from
+4 −4
Draft

Tests: Make data providers in canonical.php static #14792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/phpunit/tests/canonical.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function test_canonical( $test_url, $expected, $ticket = 0, $expected_doi
$this->assertCanonical( $test_url, $expected, $ticket, $expected_doing_it_wrong );
}

public function data_canonical() {
public static function data_canonical() {
/*
* Data format:
* [0]: Test URL.
Expand Down Expand Up @@ -345,7 +345,7 @@ public function test_redirect_guess_404_permalink_with_custom_statuses( $status_
* bool Whether the 404 link is expected to redirect
* }
*/
public function data_redirect_guess_404_permalink_with_custom_statuses() {
public static function data_redirect_guess_404_permalink_with_custom_statuses() {
return array(
'public status' => array(
'status_args' => array( 'public' => true ),
Expand Down Expand Up @@ -395,7 +395,7 @@ public function test_redirect_guess_404_permalink_post_types( $original_url, $ex
*
* @return array[]
*/
public function data_redirect_guess_404_permalink_post_types() {
public static function data_redirect_guess_404_permalink_post_types() {
return array(
'single string formatted post type' => array(
'original_url' => '/?name=sample-pag&post_type=page',
Expand Down Expand Up @@ -673,7 +673,7 @@ public function test_canonical_attachment_page_redirect_with_option_disabled( $e
*
* @return array[]
*/
public function data_canonical_attachment_page_redirect_with_option_disabled() {
public static function data_canonical_attachment_page_redirect_with_option_disabled() {
return array(
'logged out user, no parent' => array(
'%%attachment_url%%',
Expand Down
Loading