Skip to content

fix: settings submenu flag sizing and Back label alignment - #3119

Merged
abjt14 merged 1 commit into
mainfrom
abhijeet/nav-settings-menu-qa
Oct 6, 2026
Merged

fix: settings submenu flag sizing and Back label alignment#3119
abjt14 merged 1 commit into
mainfrom
abhijeet/nav-settings-menu-qa

Conversation

@abjt14

@abjt14 abjt14 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
Before After
Screenshot 2026-10-05 at 18 08 32 Screenshot 2026-10-05 at 18 09 37
Screenshot 2026-10-05 at 18 10 26 Screenshot 2026-10-05 at 18 10 34

@abjt14
fix: settings submenu flag sizing and Back label alignment
6260868 
- The language flags lost their 20x14 icon slot when the list moved onto
  SettingsSubmenuList (#3108). The flag <img> is sized 100% of its slot, so
  the viewBox-only en/es/fr SVGs stretched to the menu's full width (el.svg
  ships its own 20x20 size, which is why Greek stayed small). The slot now
  gives image icons a 20x14 box with 2px rounding again.
- The Back row used a 10px icon gap against the options' 8px, putting its
  label 2px right of the option labels. Every leading slot (Back chevron,
  theme glyph, flag) is now one fixed 20px width with the glyph centred and
  an 8px gap, so the labels share one column in both submenus. Equal gaps
  alone wouldn't have aligned the Language list: the flags are 20px wide
  against 18px glyphs.
- The mobile drawer widens that slot to 28px to fit its 24px glyphs and
  28x20 flags. `:first-child` targets only the leading slot, since the
  selected-option check comes after the label.
@abjt14 abjt14 self-assigned this Oct 5, 2026
@odin-by-borg

odin-by-borg Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Mjolnir Security Review

VerdictCLEAN · 0 findings
Commit6260868 · 5s

No security vulnerabilities identified in the reviewed changes. The PR only adjusts CSS for mobile menu and settings submenu icon slots (widths, heights, alignment, and overflow on flag images). There are no user-controlled inputs, security-sensitive sinks, or behavioural changes beyond presentation.

View in Odin

30 PRs reviewed · 1 finding

@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Oct 5, 2026 9:11am UTC

Request Review

@abjt14
abjt14 requested review from lochie and sammdec October 5, 2026 09:11
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.34 MB (🟡 +37 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@abjt14
abjt14 merged commit a0e046e into main Oct 6, 2026
28 checks passed
@abjt14
abjt14 deleted the abhijeet/nav-settings-menu-qa branch October 6, 2026 05:21

This branch was successfully deployed

1 active deployment
Preview — 6260868c Deployed Oct 5, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sammdec sammdec sammdec approved these changes
@lochie lochie lochie approved these changes

Assignees

@abjt14 abjt14

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abjt14 @sammdec @lochie