Skip to content

fix: settings submenu flag sizing and Back label alignment #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abjt14 merged 1 commit into from
Oct 6, 2026
Merged

fix: settings submenu flag sizing and Back label alignment #3119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/layouts/MobileMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ const menuListSx = {
// 3rem row. Only currentColor SvgIcons are caught — the language flags are `<img>` and carry
// their own responsive box.
'& .MuiSvgIcon-root': { fontSize: '1.5rem' },
// The language flags are `<img>`, not currentColor glyphs, so they scale by box rather than
// font-size. `:has(img)` keeps this off the Back chevron and check slots in the same list.
'& .MuiListItemIcon-root:has(img)': { width: 28, height: 20 },
// The submenus' leading icon slot (the check trails, never first) widens for 28x20 flags.
'& .MuiListItemIcon-root:first-child': { width: 28 },
'& .MuiListItemIcon-root:has(img)': { height: 20 },
};

// The hamburger (three rounded lines, per the design SVG) that morphs into an X. Rendered inside
Expand Down
11 changes: 8 additions & 3 deletions src/layouts/components/SettingsSubmenuList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@ import { ReactNode } from 'react';
import { CheckIcon } from 'src/components/icons/CheckIcon';
import { ChevronLeftIcon } from 'src/components/icons/ChevronLeftIcon';

// Chevron/icon-to-label gap, per the design spec — the Back row runs 2px wider than an option.
const BACK_ICON_SX = { mr: '0.625rem', color: 'fg-chevron' };
const OPTION_ICON_SX = { mr: '0.5rem', color: 'fg-3' };
const ICON_SLOT_SX = {
width: '1.25rem',
mr: '0.5rem',
justifyContent: 'center',
'&:has(img)': { height: '0.875rem', borderRadius: '2px', overflow: 'hidden' },
};
const BACK_ICON_SX = { ...ICON_SLOT_SX, color: 'fg-chevron' };
const OPTION_ICON_SX = { ...ICON_SLOT_SX, color: 'fg-3' };
const ROW_SX = { cursor: 'pointer', color: 'fg-1' };

interface SettingsSubmenuOption {
Expand Down
Loading