Repository navigation
Add ESP32-S3 Super Mini board support - #11557
unconditional wants to merge 3 commits into
Conversation
|
I seem to have collided with you because we were both trying to get this board added to CircuitPython this afternoon. You might check out my PR #11563. I really don't have a preference whether your or my PR gets merged. I do have a few notes: Edit: Dropped Neopixed GRB comment
|
|
@grgrant I also don't have any preference which PR is merged as long as the board is supported as soon as possible. Regarding the questions:
|
|
We generally don't assign We could be argued out of that, but it's been our style. If you have not seen https://learn.adafruit.com/how-to-add-a-new-board-to-circuitpython/, it's worth looking at. |
VID/PIDThis was my first board so I was figuring things out. I'm pretty positive you need: In the learn guide Dan linked to above there is a FAQ entry talking about the USB VID/PIDs. Adafruit requires each different hardware have a unique VID/PID pair for each mode. In the FAQ entry on "Why does Circuit Python require a VID:PID for every board definition" it says:
And as I noted in my PR the person creating the boot loader for tinyuf2 in 2024 already registered three VID:PIDs for the board with espressif. espressif/usb-pids#183 https://github.com/espressif/usb-pids/pull/183/changes Pin CommentsWhen I created my pin list I followed a similar board either the MakerGo ESP32C3 or C6 Supermini. It has all the under board pads. While not every board does this (the QyPy ESP32S3 doesnt), the MakerGo version also defined IO1, IO2 IO3 ... That would make a ton of pin defs due to how many are present on the SuperMini but apparently the MakerGo folks thought it nice to have the IO versions. They did not have SCL and SDA defined since their boards don't show those pins. Some vendors don't have a silk screen but their online resource will call out a SDA/SCL pin. In the case of the ESP32S2 Supermini no docs I see have called out specific SDA/SCL so I can see why Dan suggested removing the I2C definition. |
|
Thanks for this! I merge in #11563 because it has a valid USB PID. This one is the bootloader PID I believe. |
Add ESP32-S3 Super Mini board support
Board specifications
Battery monitoring: VBAT=GPIO10 (board.VBAT), VBUS=GPIO33 (board.VBUS)Pin mappings
Reference
Board documentation: https://www.espboards.dev/esp32/esp32-s3-super-mini/
Testing