Repository navigation
refactor(@angular/build): use import resolution-mode for rolldown-plugin-dts types - #34334
Merged
alan-agius4 merged 1 commit intoOct 13, 2026
Merged
Conversation
…gin-dts types
Use `{ with: { 'resolution-mode': 'import' } }` on the dynamic import type assertion for `rolldown-plugin-dts` and remove the custom ambient module declaration file (`types.d.ts`).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the dynamic import of "rolldown-plugin-dts" in "bundler.ts" to explicitly use ESM resolution mode via import attributes. Additionally, the local ambient module declaration file for "rolldown-plugin-dts" has been removed. I have no feedback to provide.
alan-agius4
added
target: minor
clydin
approved these changes
Oct 13, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
{ with: { 'resolution-mode': 'import' } }on the dynamic import type assertion forrolldown-plugin-dtsand remove the custom ambient module declaration file (types.d.ts).