Skip to content

refactor(@angular/build): use import resolution-mode for rolldown-plugin-dts types #34334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Oct 13, 2026
Merged

refactor(@angular/build): use import resolution-mode for rolldown-plugin-dts types #34334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/angular/build/src/builders/library/pipeline/bundler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,10 @@ async function bundleAllDts(
// Ensure Rolldown's native binding is initialized via `loadRolldown()` before evaluating
// `rolldown-plugin-dts`, which has top-level imports of `rolldown/experimental`.
await loadRolldown();
const { dts } = await import('rolldown-plugin-dts');
const { dts } = (await import('rolldown-plugin-dts' as string)) as typeof import(
'rolldown-plugin-dts',
{ with: { 'resolution-mode': 'import' } }
);

const dtsSourcemap = !!options.declarationMap;
// Filter out `rolldown-plugin-dts:resolver` because all `.d.ts` files are already emitted
Expand Down
54 changes: 0 additions & 54 deletions packages/angular/build/src/builders/library/pipeline/types.d.ts
View file
Open in desktop

This file was deleted.

Loading