Repository navigation
Conversation
jlongster
force-pushed
the
sidebar-fade
branch
from
October 21, 2026 19:29
fbe95c9 to
27abdda
Compare
jlongster
force-pushed
the
sidebar-fade
branch
from
October 21, 2026 19:29
27abdda to
89cd8a8
Compare
3 of 6 tasks
Collaborator
Author
jlongster
added a commit
that referenced
this pull request
Oct 21, 2026
jlongster
added a commit
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Changes how the left sidebar and the side panel open and close. #56996 made them instant. #57692 (merged today) brought motion back by springing their real layout width every frame, tunable from the Motion workspace's Knobs "Sidebars" section. This PR replaces that width spring, and the "Sidebars" Knobs section with it, with the values James picked in the real app, hardcoded:
cubic-bezier(0.44, 0.75, 0.63, 1.03)over 180ms, no delay.Why it's cheap:
transformandopacity. The spring is sampled once into a CSSlinear()easing; a unit test checks it point by point against x(t) = 1 − (1 + ωt)e^(−ωt) with ω = 2π/0.24.Code:
shell/panel-motion.ts:createPanelMotion({ open, element, offset, identity })plays the opening and exposeswhenSettled(focus moves into the panel after it lands).panelsMovingstill hides native views during an opening.releaseClosedFocusreplacesguardClosingFocus: with no closing flight, it only moves focus out at the moment of close.sync, and the closing-pointer blockers are removed.sidebar-toggle.tsxand the titlebar'shandoffgo back to their pre-feat(app): bring back tunable sidebar motion #57692 versions.SideRegionloses itspresentprop.content-visibility: hiddenwhen closed, so reopens don't remount.Known: the side region still mounts on its first open, as before; the fade plays through that stall on the compositor.
How did you verify your code works?
bun typecheckinpackages/app.bun test --conditions=browser --isolate --preload ./happydom.ts ./test-browser/panel-motion.test.ts: 7 pass. Covers the exact keyframes, easings, durations and spring samples; instant close cancelling an opening and dropping its queued work; keyboard; reduced motion; layout switch; and focus release on close.e2e/regression/panel-edges.spec.tsis updated for the instant close: the layout moves in one frame, an open fades over several frames from 0.15, a close doesn't animate, and keyboard toggles don't animate, in LTR and RTL.Screenshots / recordings
Recordings of an earlier revision are on the team canvas, group "Sidebar motion": https://jamesbox.exe.xyz/canvas/c/mSxZCqwqak. James is checking this revision directly.
Checklist