Repository navigation
feat(app): add a "James" option for sidebar motion - #57901
Merged
Merged
Conversation
3 of 6 tasks
jlongster
force-pushed
the
low-movement-sidebars
branch
4 times, most recently
from
October 21, 2026 20:54
9eaeebe to
41f3517
Compare
jlongster
force-pushed
the
low-movement-sidebars
branch
from
October 21, 2026 21:22
b255909 to
5c211ea
Compare
…e the layout experiment
…a 30px panel shift
jlongster
force-pushed
the
low-movement-sidebars
branch
from
October 21, 2026 21:32
a3480ed to
01ae89f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Builds on Kit's #57692. It adds James as an entry in the Knobs preset strip (dev tools → Knobs → Sidebars), next to Shipped / Snappy / Smooth / Calm.
sidebars.low.*prefix, so tuned Knobs values survive the rename.What James does, for both the left sidebar and the side panel:
paintsnapped to open). Then only the panel moves: it shifts in from 30px (side panel; "Panel shift" knob, 0–48) or 10px (left sidebar), mirrored in RTL, on a 240ms spring with bounce 0, while it fades from opacity 0.15 to 1 oncubic-bezier(0.44, 0.75, 0.63, 1.03)over 180ms.transformandopacity: no per-frame layout, and the compositor plays them through main-thread work. The spring is sampled once into a CSSlinear()easing.Changes:
ui/src/motion-tuning.tsandmotion-tuning-panel.ts(a mode can ship on withvalue: true, and shows in the strip only on its own section's tab):whenon any knob. The panel shows only knobs whosewhenholds, and rebuilds when that changes.modeknob kind. It shows as a preset-strip entry rather than a row, is on while chosen, and is off once another preset is chosen; that other preset is then re-applied after the rebuild so it reaches the knobs that came back.easingknob kind (a cubic-bezier, saved as four numbers). The panel renders it with knobs' owneasing()editor.app/src/shell/panel-motion.ts:sidebars.lowmode. Kit's Motion choice is back to Spring / Instant only;fade()branch increatePanelMotion, used whenelementandoffsetare passed.whenSettled,syncandpanelsMovingcover both kinds of flight.shell.tsxandsession/screen.tsx: pass the panel layer (element) and itsoffset. Kit'spaintis unchanged.How did you verify your code works?
bun typecheckinpackages/appandpackages/ui.bun test --conditions=browser --isolate --preload ./happydom.ts ./test-browser/panel-motion.test.ts: 14 pass (including which controls show for each Motion choice). Kit's tests are unchanged; there are new James cases for:uimotion-tuning.test.tsandappmotion-tuning-panel.test.tspass.bun run lint:changed origin/betais clean.James is trying it in the web app.
e2e/regression/panel-edges.spec.tsnow seeds Kit's spring ("sidebars.low": 0), because that spec covers Kit's spring and James is now the default. Not run locally.Screenshots / recordings
None. James is checking it live.
Checklist