Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
============================================
+ Coverage 86.54% 87.22% +0.68%
+ Complexity 9787 91 -9696
============================================
Files 532 499 -33
Lines 35516 33521 -1995
Branches 6194 5849 -345
============================================
- Hits 30738 29240 -1498
+ Misses 3518 3162 -356
+ Partials 1260 1119 -141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aherbert
reviewed
Oct 27, 2026
| doTestTransformReal(16, 1e-13, 2 * EPSILON, norm[i], type); | ||
| doTestTransformReal(32, 1e-12, 4 * EPSILON, norm[i], type); | ||
| doTestTransformReal(64, 1e-12, 4 * EPSILON, norm[i], type); | ||
| doTestTransformReal(64, 1e-12, 8 * EPSILON, norm[i], type); |
Contributor
There was a problem hiding this comment.
This is not related to this PR. Please revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MATH-1679.
The
MultivariateFunctionMappingAdapteraccepted equal finite lower and upper bounds. That creates a degenerate bounded mapping even though the constructor documents a valid interval and the mapping functions require a non-zero range.This change rejects equal finite bounds with
NumberIsTooSmallExceptionand adds a regression test. Equal infinite bounds remain accepted for the existing unbounded-variable representation.Tests:
mvn clean verifyMultivariateFunctionMappingAdapterTest(5 tests)