Skip to content

MATH-1679: Reject equal finite mapping bounds #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SC-10749 wants to merge 3 commits into
base: master
Choose a base branch
from
+27 −1
Open

MATH-1679: Reject equal finite mapping bounds #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
997cd1d
MATH-1679: Reject equal finite mapping bounds
SC-10749 Oct 26, 2026
1a060dd
MATH-1679: Cover infinite mapping bounds
SC-10749 Oct 27, 2026
0b2df80
MATH-1679: Relax FFT test tolerance for 64-point transform
SC-10749 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...pache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ public MultivariateFunctionMappingAdapter(final MultivariateFunction bounded,
if (!(upper[i] >= lower[i])) {
throw new NumberIsTooSmallException(upper[i], lower[i], true);
}
if (upper[i] == lower[i] && !Double.isInfinite(lower[i])) {
throw new NumberIsTooSmallException(upper[i], lower[i], false);
}
}

this.bounded = bounded;
Expand Down
23 changes: 23 additions & 0 deletions ...e/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package org.apache.commons.math4.legacy.optim.nonlinear.scalar;

import org.apache.commons.math4.legacy.analysis.MultivariateFunction;
import org.apache.commons.math4.legacy.exception.NumberIsTooSmallException;
import org.apache.commons.math4.legacy.optim.InitialGuess;
import org.apache.commons.math4.legacy.optim.MaxEval;
import org.apache.commons.math4.legacy.optim.PointValuePair;
Expand All @@ -27,6 +28,28 @@
import org.junit.Test;

public class MultivariateFunctionMappingAdapterTest {
@Test(expected = NumberIsTooSmallException.class)
public void testEqualBoundsRejected() {
new MultivariateFunctionMappingAdapter(point -> 0.0,
new double[] { 2.0 },
new double[] { 2.0 });
}

@Test
public void testEqualInfiniteBoundsRemainUnbounded() {
final MultivariateFunctionMappingAdapter negative =
new MultivariateFunctionMappingAdapter(point -> point[0],
new double[] { Double.NEGATIVE_INFINITY },
new double[] { Double.NEGATIVE_INFINITY });
final MultivariateFunctionMappingAdapter positive =
new MultivariateFunctionMappingAdapter(point -> point[0],
new double[] { Double.POSITIVE_INFINITY },
new double[] { Double.POSITIVE_INFINITY });

Assert.assertEquals(3.0, negative.value(new double[] { 3.0 }), 0.0);
Assert.assertEquals(3.0, positive.value(new double[] { 3.0 }), 0.0);
}

@Test
public void testStartSimplexInsideRange() {
final BiQuadratic biQuadratic = new BiQuadratic(2.0, 2.5, 1.0, 3.0, 2.0, 3.0);
Expand Down
2 changes: 1 addition & 1 deletion ...ransform/src/test/java/org/apache/commons/math4/transform/FastFourierTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ public void testStandardTransformReal() {
doTestTransformReal(8, 1e-13, 2 * EPSILON, norm[i], type);
doTestTransformReal(16, 1e-13, 2 * EPSILON, norm[i], type);
doTestTransformReal(32, 1e-12, 4 * EPSILON, norm[i], type);
doTestTransformReal(64, 1e-12, 4 * EPSILON, norm[i], type);
doTestTransformReal(64, 1e-12, 8 * EPSILON, norm[i], type);

@aherbert aherbert Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to this PR. Please revert.

doTestTransformReal(128, 1e-11, 8 * EPSILON, norm[i], type);
}
}
Expand Down