chore: add missing since versions to #[deprecated] attributes - #24544
Open
alamb wants to merge 1 commit into
Open
chore: add missing since versions to #[deprecated] attributes#24544alamb wants to merge 1 commit into
since versions to #[deprecated] attributes#24544alamb wants to merge 1 commit into
Conversation
The API health policy requires deprecated APIs to specify the DataFusion version they were deprecated in, so the removal clock can be evaluated. Five attributes on main had no `since`. Each version was determined from the release that first contained the commit which added the attribute.
github-actions
Bot
added
optimizer
alamb
commented
Aug 20, 2026
alamb
left a comment
alamb
left a comment
Contributor
Author
There was a problem hiding this comment.
Provenance for each since version: the PR that added the #[deprecated] attribute, and the release that first contained that commit (git tag --contains).
|
|
||
| /// Create an aggregate expression with a name from a logical expression | ||
| #[deprecated(note = "use LoweredAggregateBuilder")] | ||
| #[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")] |
Contributor
Author
|
|
||
| /// Create an aggregate expression from a logical expression or an alias | ||
| #[deprecated(note = "use LoweredAggregateBuilder")] | ||
| #[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")] |
Contributor
Author
| // under the License. | ||
|
|
||
| #[deprecated( | ||
| since = "47.0.0", |
Contributor
Author
| /// | ||
| /// Deprecated: use [`Filter::try_new`] directly. | ||
| #[deprecated] | ||
| #[deprecated(since = "55.0.0", note = "Use `Filter::try_new` instead")] |
Contributor
Author
|
|
||
| /// Alias for [`mpsc_channel`]. | ||
| #[deprecated(note = "Use mpsc_channel instead")] | ||
| #[deprecated(since = "55.0.0", note = "Use mpsc_channel instead")] |
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24544 +/- ##
==========================================
- Coverage 81.32% 81.31% -0.01%
==========================================
Files 1117 1117
Lines 396269 396269
Branches 396269 396269
==========================================
- Hits 322260 322245 -15
- Misses 55186 55194 +8
- Partials 18823 18830 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
marked this pull request as ready for review
August 20, 2026 20:48
Rich-T-kid
approved these changes
Aug 21, 2026
Comment on lines
18
to
22
| #[deprecated( | ||
| since = "47.0.0", | ||
| note = "overlay has been moved to core. Update imports to use core::overlay." | ||
| )] | ||
| pub use crate::core::overlay::*; |
Contributor
There was a problem hiding this comment.
cant this be removed from the codebase now since its been two releases?
Jefffrey
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The API health policy deprecation guidelines say:
Five
#[deprecated]attributes onmainhave nosince, so there is no way to tell when they can be removedWhat changes are included in this PR?
Adds
sinceto each of the five. The version is the release that first contained the commit which added the attribute, determined withgit tag --contains:Are these changes tested?
CI
Are there any user-facing changes?
No