Skip to content

chore: add missing since versions to #[deprecated] attributes #24544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alamb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add missing since versions to #[deprecated] attributes #24544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/core/src/physical_planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2560,7 +2560,7 @@ type AggregateExprWithOptionalArgs = (
);

/// Create an aggregate expression with a name from a logical expression
#[deprecated(note = "use LoweredAggregateBuilder")]
#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")]

@alamb alamb Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in #21739 (commit 5cf8eef, 2026-05-17), first released in 54.0.0.

pub fn create_aggregate_expr_with_name_and_maybe_filter(
e: &Expr,
name: Option<String>,
Expand All @@ -2587,7 +2587,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter(
}

/// Create an aggregate expression from a logical expression or an alias
#[deprecated(note = "use LoweredAggregateBuilder")]
#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")]

@alamb alamb Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in #21739 (commit 5cf8eef, 2026-05-17), first released in 54.0.0.

pub fn create_aggregate_expr_and_maybe_filter(
e: &Expr,
logical_input_schema: &DFSchema,
Expand Down
1 change: 1 addition & 0 deletions datafusion/functions/src/string/overlay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// under the License.

#[deprecated(
since = "47.0.0",

@alamb alamb Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in #15217 (commit 45ed5aa, 2025-03-25), first released in 47.0.0.

note = "overlay has been moved to core. Update imports to use core::overlay."
)]
pub use crate::core::overlay::*;
Comment on lines 18 to 22

@Rich-T-kid Rich-T-kid Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant this be removed from the codebase now since its been two releases?

2 changes: 1 addition & 1 deletion datafusion/optimizer/src/push_down_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,7 @@ fn rewrite_projection(
/// Creates a new LogicalPlan::Filter node.
///
/// Deprecated: use [`Filter::try_new`] directly.
#[deprecated]
#[deprecated(since = "55.0.0", note = "Use `Filter::try_new` instead")]

@alamb alamb Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in #21668 (commit d318324, 2026-05-21), first released in 55.0.0.

Note this landed just after branch-54 was cut, so it is 55.0.0 rather than 54.0.0 despite the merge date.

pub fn make_filter(predicate: Expr, input: Arc<LogicalPlan>) -> Result<LogicalPlan> {
Filter::try_new(predicate, input).map(LogicalPlan::Filter)
}
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/spill/spill_pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ pub fn spsc_channel(
}

/// Alias for [`mpsc_channel`].
#[deprecated(note = "Use mpsc_channel instead")]
#[deprecated(since = "55.0.0", note = "Use mpsc_channel instead")]

@alamb alamb Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in #23522 (commit 12fa0ce, 2026-07-16), first released in 55.0.0.

pub fn channel(
max_file_size_bytes: usize,
spill_manager: Arc<SpillManager>,
Expand Down