mod_authnz_fcgi: log FastCGI stderr using the received length - #779
Open
arshsmith1 wants to merge 1 commit into
Open
arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_response reads an AP_FCGI_STDERR record into readbuf via recv_data (apr_socket_recv), which stores exactly readbuflen bytes and does not NUL-terminate it, but the log call then formats readbuf with %s and keeps reading past those bytes into the uninitialized stack buffer, and off the end of it when the content has no NUL. The sibling mod_proxy_fcgi already logs its stderr record with '%.*s' and (int)readbuflen, so this matches that here. Any stderr output from the configured authorizer reaches this path, and the trailing bytes land in the error log.