Skip to content

mod_authnz_fcgi: log FastCGI stderr using the received length #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arshsmith1 wants to merge 1 commit into from
Closed

mod_authnz_fcgi: log FastCGI stderr using the received length #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changes-entries/authnz-fcgi-stderr-bound.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*) mod_authnz_fcgi: Log the content of a FastCGI stderr record using its
received length instead of treating the buffer as a C string, avoiding a
read past the received bytes. [arshiya tabasum]
4 changes: 2 additions & 2 deletions modules/aaa/mod_authnz_fcgi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,8 +629,8 @@ static apr_status_t handle_response(const fcgi_provider_conf *conf,
case AP_FCGI_STDERR: /* Text to log */
if (clen) {
ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
APLOGNO(02507) "%s: Logged from %s: '%s'",
fn, conf->backend, readbuf);
APLOGNO(02507) "%s: Logged from %s: '%.*s'",
fn, conf->backend, (int)readbuflen, readbuf);
}

if (clen > readbuflen) {
Expand Down