Data, Spark: Add format model TCK coverage for vectorized reads (WIP) - #17610
Draft
joyhaldar wants to merge 1 commit into
Draft
Data, Spark: Add format model TCK coverage for vectorized reads (WIP)#17610joyhaldar wants to merge 1 commit into
joyhaldar wants to merge 1 commit into
Conversation
Co-authored-by: Joy Haldar <joy.haldar@target.com>
pvary
reviewed
Aug 12, 2026
| return false; | ||
| } | ||
|
|
||
| protected Set<FileFormat> supportedFormats() { |
Contributor
There was a problem hiding this comment.
I don't really like this one.
Could we just re-define FILE_FORMATS, and FORMAT_AND_GENERATOR in TestSparkVectorizedFormatModel?
private static final FileFormat[] FILE_FORMATS = {FileFormat.ORC, FileFormat.PARQUET};
private static final List<Arguments> FORMAT_AND_GENERATOR
This relies on the fact, how junit works internally, but no change is required in all of the tests.
I'm open for other ideas as well, this is just the first one occured to me
pvary
reviewed
Aug 12, 2026
| return false; | ||
| } | ||
|
|
||
| protected boolean readOnly() { |
Contributor
There was a problem hiding this comment.
Shall we split the base test class to read-tests, and read+write-tests?
Using this method in all test seem awkward a bit.
If we decide so, we might want to do it in a different PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a TCK subclass for Spark's vectorized
ColumnarBatchread path.Four base class changes were needed:
readOnly()- vectorized models register readers only, so write tests are skipped.supportedFormats()-Avrohas noColumnarBatchmodel registeredassertRecordsEqual()- read tests built expectations viaconvertToEngineRecords, which can't work for a batch type