Skip to content

fix: correct README description of MISSION.md - #1019

Merged
potiuk merged 1 commit into
apache:mainfrom
cyforkk:fix/readme-mission
Jul 30, 2026
Merged

fix: correct README description of MISSION.md#1019
potiuk merged 1 commit into
apache:mainfrom
cyforkk:fix/readme-mission

Conversation

@cyforkk

@cyforkk cyforkk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary\n\nThis PR resolves #1006 by fixing the inconsistent description of MISSION.md in the README.\n\n## Changes\n\n- Changed 'draft project-establishment proposal' to 'founding mission of the established TLP'\n- Now consistent with line 48 and the status banner in MISSION.md\n\n## Verification\n\n- [x] Cross-references entry no longer calls MISSION.md a draft\n- [x] Consistent with line 48 and MISSION.md status banner

Change 'draft project-establishment proposal' to 'founding mission
of the established TLP' for consistency with line 48.

Closes apache#1006

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — this corrects a genuinely stale line. MISSION.md has carried a banner describing itself as "the original establishment proposal, kept as a historical record of the project's founding mission" since Magpie was established as a TLP, while this README bullet still called it a draft project-establishment proposal. Minimal, targeted diff; CI green.

One heads-up so it isn't a surprise: #1040 changes this exact same line with equivalent intent. Yours was opened first and stays closer to the existing bullet structure, so this is the one I'm approving — a maintainer will close the other as a duplicate. Nothing for you to do here.

Smaller observations

  • README.md:238established TLP is a little more clipped than the phrasing this README already uses for the same document a few lines up (line 48: "the founding mission of the Apache Magpie Top-Level Project, originally filed as its establishment proposal"). Aligning the two would be marginally more consistent, but it is not worth a round-trip on a one-line docs fix.

Thanks for the first contribution to Apache Magpie.


This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.

More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md § Opening a pull request.

@potiuk
potiuk merged commit 1b10051 into apache:main Jul 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the README describing MISSION.md as a draft proposal in one place and established in another

2 participants