Skip to content

docs: align MISSION.md cross-reference with established-TLP framing - #1040

Closed
NekomyaDev wants to merge 1 commit into
apache:mainfrom
NekomyaDev:fix-mission-crossref
Closed

docs: align MISSION.md cross-reference with established-TLP framing#1040
NekomyaDev wants to merge 1 commit into
apache:mainfrom
NekomyaDev:fix-mission-crossref

Conversation

@NekomyaDev

Copy link
Copy Markdown
Contributor

Fixes #1006.

The Cross-references entry still called MISSION.md a draft project-establishment proposal, contradicting line 48 ("the founding mission of the established TLP") and the status banner in MISSION.md itself (established by ASF Board resolution on 17 June 2026; the original proposal kept as a historical record).

One-line change: the entry now matches both, and still tells the reader what is inside (motivation, scope, design commitments, initial PMC composition target).

Docs-only single-line edit; relying on PR CI for the prek pass.

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this — the line is genuinely stale, and your replacement is well grounded: it is close to verbatim from MISSION.md's own banner ("the original establishment proposal, kept as a historical record"), which is exactly the right source to align against.

The catch is ownership rather than content: #1019 changes this identical line with the same intent and was opened first. Both branches start from the same README.md blob, so they conflict by construction — only one can land. I have approved that one, which means this PR is heading for a close-as-duplicate rather than a merge. That is first-come on an identical edit, not a judgement on your change.

Smaller observations

  • README.md:238 — independent of the duplicate question, worth knowing for next time: the bullet already opens with an em-dash separator, so adding a second one mid-sentence leaves the line carrying two em dashes plus a colon. AGENTS.md § Writing and editing documentation asks that contributors "Use em dashes sparingly" and "Prefer small, targeted edits over rewrites" — the shorter form keeps the surrounding list rhythm intact.

Your other open PR, #1032, touches different files and is unaffected by this. Thanks for both — please do keep them coming.


This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The findings
below are observations, not blockers; an Apache Magpie
maintainer — a real person — will take the next look at the
PR. If you think a finding is mis-applied, please reply on
the PR and a maintainer will weigh in.

More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md § Opening a pull request.

@potiuk

potiuk commented Jul 30, 2026

Copy link
Copy Markdown
Member

Closing as a duplicate of #1019, which edits the same README.md line and was opened first — see the review above for the detail. Thanks again for spotting the stale wording; your other PR, #1032, is unaffected.

@potiuk potiuk closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the README describing MISSION.md as a draft proposal in one place and established in another

2 participants