Skip to content

fix(build): restore GCC Release compilation on Linux - #539

Merged
lxy-9602 merged 12 commits into
apache:mainfrom
lucasfang:codex/linux-arm64-gcc13-build-only
Nov 10, 2026
Merged

lxy-9602 merged 12 commits into
apache:mainfrom
lucasfang:codex/linux-arm64-gcc13-build-only

Conversation

@lucasfang

@lucasfang lucasfang commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Purpose

Fix GCC Release compilation failures on Linux. Addresses #537; macOS work continues in #538.

  • Avoid optional and vector initialization patterns that trigger GCC's optimized-build diagnostics. Pass explicit int64_t values to Lumina options for GCC 9 compatibility.
  • Pass the project C++ standard to Boost.Build. Use concrete Arrow builders and access nested builders through their parents. Initialize test data directly where GCC 16 reports optimized-build bounds or null-pointer warnings.
  • Patch OSS SDK v2 to read expiration metadata through a const reference instead of copying its variant value, avoiding GCC 12's maybe-uninitialized error.
  • Add the Linux ARM64 GCC 13.3.0 Release job and select Lumina's AArch64 library. Cache verified release assets used by the build tools.

No optional modules or warning checks are disabled by these fixes.

Tests

  • Full validation of PR snapshot e5686430 with upstream GCC 15.3.0 on Ubuntu 24.04 x86_64 passed: Release C++17 -O3 -Wall -Werror, every optional module, static/shared libraries and benchmarks enabled, 43/43 CTest targets, and the installed CMake consumer check.
  • GCC 16.2.0 passed the full Release build on Ubuntu 24.04 x86_64 at f41ddbec with C++17, -O3 -Wall -Werror, all optional modules, static and shared libraries, and benchmarks enabled. All 43 CTest targets passed. The installed CMake consumer built, linked, and ran successfully.
  • Before the GCC 16 fixes, recompiled the nine C++ files changed at that point with GCC 9.5, 10.5, 11.5, 12.4 and 13.3 on Ubuntu 24.04 x86_64: 45/45 passed. Used the configured Release target flags (-O3 -DNDEBUG -Wall -Werror, C++17) and existing dependency/generated headers; this is compilation validation, not a new full runtime run of the integrated branch.
  • Before PR integration, the GCC 9 and 12 fix snapshots passed full builds, all 43 CTest targets and the installed CMake consumer check with all optional modules and benchmarks enabled. The GCC 10 and 11 baselines passed the same full checks. Final modified C++ files and the OSS patch were also compiled separately with GCC 9–11.
  • Applied the OSS patch to a fresh copy of the pinned 0.1.2 archive and compiled the patched source with GCC 9–12.
  • Passed changed-file pre-commit hooks (including Sphinx lint), git diff --check, ci/scripts/test_cmake_modules.sh and bash ci/scripts/test_download_release_asset.sh.
  • Previous ARM64 CI at ca982d86 passed all 41 CTest targets, including Lumina: CI job. CI for the new commits is pending. External network tests and sanitizers were not part of the local Release validation.

API and Format

No public API, storage format or protocol changes.

Documentation

Document Linux ARM64 Lumina support. Simplify the platform and Lumina instructions by removing repeated references to specific CI jobs, as requested in review.

Generative AI tooling

Generated-by: OpenAI Codex (GPT-6)

Comment thread docs/source/building.rst Resolved
@lucasfang lucasfang changed the title fix(build): restore Linux ARM64 GCC 13.3 Release compilation fix(build): restore GCC Release compilation on Linux Nov 10, 2026

@SteNicholas SteNicholas left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasfang, I left one comment for the new OSS SDK patch causes the RAT license check to fail. PTAL.

Comment thread cmake_modules/oss_sdk_v2.diff Resolved
SteNicholas
SteNicholas previously approved these changes Nov 10, 2026

@SteNicholas SteNicholas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lxy-9602
lxy-9602 previously approved these changes Nov 10, 2026

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602
lxy-9602 merged commit 0bc15ae into apache:main Nov 10, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants