Repository navigation
fix(build): restore GCC Release compilation on Linux - #539
Merged
lxy-9602 merged 12 commits intoNov 10, 2026
Merged
Conversation
zjw1111
reviewed
Nov 10, 2026
SteNicholas
reviewed
Nov 10, 2026
Member
There was a problem hiding this comment.
@lucasfang, I left one comment for the new OSS SDK patch causes the RAT license check to fail. PTAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix GCC Release compilation failures on Linux. Addresses #537; macOS work continues in #538.
int64_tvalues to Lumina options for GCC 9 compatibility.maybe-uninitializederror.No optional modules or warning checks are disabled by these fixes.
Tests
e5686430with upstream GCC 15.3.0 on Ubuntu 24.04 x86_64 passed: Release C++17-O3 -Wall -Werror, every optional module, static/shared libraries and benchmarks enabled, 43/43 CTest targets, and the installed CMake consumer check.f41ddbecwith C++17,-O3 -Wall -Werror, all optional modules, static and shared libraries, and benchmarks enabled. All 43 CTest targets passed. The installed CMake consumer built, linked, and ran successfully.-O3 -DNDEBUG -Wall -Werror, C++17) and existing dependency/generated headers; this is compilation validation, not a new full runtime run of the integrated branch.git diff --check,ci/scripts/test_cmake_modules.shandbash ci/scripts/test_download_release_asset.sh.ca982d86passed all 41 CTest targets, including Lumina: CI job. CI for the new commits is pending. External network tests and sanitizers were not part of the local Release validation.API and Format
No public API, storage format or protocol changes.
Documentation
Document Linux ARM64 Lumina support. Simplify the platform and Lumina instructions by removing repeated references to specific CI jobs, as requested in review.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)