Repository navigation
fix(build): restore GCC Release compilation on Linux #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lxy-9602
merged 12 commits into
apache:main
from
lucasfang:codex/linux-arm64-gcc13-build-only
Nov 10, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6c4afd8
fix(build): restore Linux ARM64 GCC 13.3 Release compilation
lucasfang cc9b7bc
fix(test): avoid retaining the cached backend in the eviction test
lucasfang 21ac1ae
ci: cover GCC 13.3 on ARM64 and cache verified release assets
lucasfang ea5ef9e
fix(lumina): enable the Linux ARM64 artifact in CI and document support
lucasfang ca982d8
ci: rerun Linux ARM64 validation with Lumina enabled
lucasfang 372f805
fix(build): resolve GCC 9 and 12 Release compilation warnings
lucasfang 68be088
docs: simplify platform and Lumina build instructions
lucasfang e568643
fix(ci): exclude OSS SDK patch from RAT license check
lucasfang e151e63
fix(build): restore GCC 16 Release compilation
lucasfang f41ddbe
test: fix GCC 16 Release compilation of remaining test targets
lucasfang 47e5375
docs: attribute the OSS SDK v2 patch in LICENSE
lucasfang 3324fa1
fix(ci): retry GCC 8 package downloads over HTTPS
lucasfang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name: Prepare release assets | ||
| description: Cache and verify pinned GitHub release archives before building | ||
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: ${{ runner.temp }}/paimon-release-assets | ||
| key: release-assets-v1-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('third_party/versions.txt', 'ci/scripts/setup_rust.sh') }} | ||
| - shell: bash | ||
| run: | | ||
| set -eu | ||
| source third_party/versions.txt | ||
| cache_dir="${RUNNER_TEMP}/paimon-release-assets" | ||
| for entry in "${DEPENDENCIES[@]}"; do | ||
| read -r var archive url <<< "${entry}" | ||
| case "${var}" in | ||
| PAIMON_ZLIB_URL|PAIMON_ZSTD_URL|PAIMON_PROTOBUF_URL|PAIMON_ARROW_URL) | ||
| checksum_var="${var%_URL}_BUILD_SHA256_CHECKSUM" | ||
| bash ci/scripts/download_release_asset.sh "${url}" "${cache_dir}/${archive}" "${!checksum_var}" | ||
| echo "${var}=${cache_dir}/${archive}" >> "${GITHUB_ENV}" | ||
| ;; | ||
| esac | ||
| done | ||
| echo "PAIMON_RELEASE_ASSET_DIR=${cache_dir}" >> "${GITHUB_ENV}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #!/usr/bin/env bash | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # Fetch a pinned GitHub release asset. Use the release API if the browser | ||
| # download endpoint times out, and publish a file only after verification. | ||
| set -euo pipefail | ||
|
|
||
| url=$1 | ||
| output=$2 | ||
| sha256=$3 | ||
|
|
||
| verify() { | ||
| if command -v sha256sum >/dev/null; then | ||
| echo "${sha256} $1" | sha256sum -c - | ||
| else | ||
| echo "${sha256} $1" | shasum -a 256 -c - | ||
| fi | ||
| } | ||
|
|
||
| if [[ -f "${output}" ]] && verify "${output}"; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| mkdir -p "$(dirname "${output}")" | ||
| tmp=$(mktemp "${output}.XXXXXX") | ||
| trap 'rm -f "${tmp}"' EXIT | ||
| curl_args=(--proto '=https' --tlsv1.2 -fsSL --retry 3 --connect-timeout 15 --max-time 180) | ||
| if ! curl "${curl_args[@]}" "${url}" -o "${tmp}" || ! verify "${tmp}"; then | ||
| release=${url#https://github.com/} | ||
| repo=${release%%/releases/download/*} | ||
| asset=${release##*/} | ||
| tag=${release#*/releases/download/} | ||
| tag=${tag%/*} | ||
| asset_url=$(curl "${curl_args[@]}" "https://api.github.com/repos/${repo}/releases/tags/${tag}" | | ||
| python3 -c 'import json, sys | ||
| print(next(a["url"] for a in json.load(sys.stdin)["assets"] if a["name"] == sys.argv[1]))' "${asset}") | ||
| curl "${curl_args[@]}" -H 'Accept: application/octet-stream' "${asset_url}" -o "${tmp}" | ||
| verify "${tmp}" | ||
| fi | ||
| mv -f "${tmp}" "${output}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| #!/usr/bin/env bash | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| set -euo pipefail | ||
|
|
||
| script="$(dirname "${BASH_SOURCE[0]}")/download_release_asset.sh" | ||
| work=$(mktemp -d) | ||
| trap 'rm -rf "${work}"' EXIT | ||
| export PATH="${work}:${PATH}" | ||
| export REQUEST_LOG="${work}/requests" | ||
| cat > "${work}/curl" <<'MOCK' | ||
| #!/usr/bin/env bash | ||
| set -eu | ||
| echo request >> "${REQUEST_LOG}" | ||
| case "$*" in | ||
| *github.com/org/repo/releases/download/*) exit 22 ;; | ||
| *api.github.com/repos/org/repo/releases/tags/v1*) | ||
| echo '{"assets":[{"name":"archive","url":"https://api.github.com/assets/123"}]}' ;; | ||
| *application/octet-stream*https://api.github.com/assets/123*) | ||
| printf '%s' "${ASSET_CONTENT:-abc}" > "${!#}" ;; | ||
| *) exit 1 ;; | ||
| esac | ||
| MOCK | ||
| chmod +x "${work}/curl" | ||
| url=https://github.com/org/repo/releases/download/v1/archive | ||
| checksum=ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad | ||
| fetch() { | ||
| bash "${script}" "${url}" "${work}/archive" "${checksum}" | ||
| } | ||
|
|
||
| fetch | ||
| [[ $(cat "${work}/archive") == abc ]] | ||
| fetch | ||
| [[ $(wc -l < "${REQUEST_LOG}") -eq 3 ]] | ||
| echo corrupt > "${work}/archive" | ||
| fetch | ||
| [[ $(cat "${work}/archive") == abc ]] | ||
| rm "${work}/archive" | ||
| if ASSET_CONTENT=invalid fetch; then | ||
| echo "Checksum mismatch accepted" >&2 | ||
| exit 1 | ||
| fi | ||
| [[ ! -e "${work}/archive" ]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| diff --git a/sdk/src/internal/ClientImplBase.cpp b/sdk/src/internal/ClientImplBase.cpp | ||
| --- a/sdk/src/internal/ClientImplBase.cpp | ||
| +++ b/sdk/src/internal/ClientImplBase.cpp | ||
| @@ -354,6 +354,6 @@ | ||
| context.signingContext.expirationInEpoch = 0; | ||
| if (input.opMetadata.find("EXPIRATION_TIME") != input.opMetadata.end()) { | ||
| - auto value = input.opMetadata.at("EXPIRATION_TIME"); | ||
| + const auto& value = input.opMetadata.at("EXPIRATION_TIME"); | ||
| if (auto* val = std::get_if<std::int64_t>(&value)) { | ||
| context.signingContext.expirationInEpoch = static_cast<std::time_t>(*val); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.