Repository navigation
WW-3655 test(freemarker): guard against resolving the result location from the request URI - #2037
Merged
Merged
Conversation
… from the request URI The behaviour was changed by WW-4169 (2.3.17): a relative location is resolved against the action namespace. The test fails when the old request-URI based resolution is restored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lukaszlenart
marked this pull request as ready for review
October 16, 2026 12:10
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WW-3655
Summary
WW-3655 reported that
FreemarkerResultbuilt a relative (or empty) location from the request URI. A request path could therefore decide which template got loaded. WW-4169 already changed this in 2.3.17: a relative location is now resolved against the action namespace.This PR adds a regression test only. No production code changes.
Test
FreeMarkerResultTest#testEmptyLocationDoesNotLoadRequestUriAsTemplatesends a request to/com/acme/actions/Action.class/with an empty result location. A recordingStringTemplateLoaderholds a template at that path. The test asserts that the loader is never asked for that path and that its content is never written to the response.main, it passes (FreeMarkerResultTest6/6,FreemarkerResultMockedTest8/8).🤖 Generated with Claude Code