Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,14 @@
import org.apache.struts2.views.jsp.StrutsMockServletContext;
import org.springframework.mock.web.MockHttpServletRequest;

import freemarker.cache.StringTemplateLoader;
import freemarker.template.Configuration;

import java.io.File;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.List;

/**
* Test case for FreeMarkerResult.
Expand Down Expand Up @@ -113,6 +118,42 @@ public void testContentTypeFromTemplate() throws Exception {
assertEquals("text/xml", response.getContentType());
}

public void testEmptyLocationDoesNotLoadRequestUriAsTemplate() throws Exception {
request.setRequestURI("/com/acme/actions/Action.class/");
request.setServletPath("/com/acme/actions/Action.class/");

List<String> requestedTemplates = new ArrayList<>();
StringTemplateLoader loader = new StringTemplateLoader() {
@Override
public Object findTemplateSource(String name) {
requestedTemplates.add(name);
return super.findTemplateSource(name);
}
};
loader.putTemplate("com/acme/actions/Action.class/", "CLASS-FILE-BYTES");
Configuration recordingConfiguration = new Configuration(Configuration.VERSION_2_3_34);
recordingConfiguration.setLocalizedLookup(false);
recordingConfiguration.setTemplateLoader(loader);

FreemarkerResult result = new FreemarkerResult() {
@Override
protected Configuration getConfiguration() {
return recordingConfiguration;
}
};
result.setLocation("");
result.setFreemarkerManager(mgr);

try {
result.execute(invocation);
} catch (Exception expected) {
// a missing template is acceptable, serving the request URI is not
}

assertFalse(stringWriter.toString().contains("CLASS-FILE-BYTES"));
assertTrue(requestedTemplates.toString(), requestedTemplates.stream().noneMatch(name -> name.contains("Action.class")));
}

protected void setUp() throws Exception {
super.setUp();
mgr = new FreemarkerManager();
Expand Down
Loading